Skip to content

Conversation

vybhav72954
Copy link
Contributor

Description

I have added a .gitignore for this project.

I have covered

  • JetBrains IDE
  • vscode
  • eclispe
  • Jupyter
  • virtualenv
  • MacOS

along with the basic ignored files.

Fixes #169

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .💯

@avinashkranjan avinashkranjan merged commit 920664c into avinashkranjan:master Jan 7, 2021
@avinashkranjan
Copy link
Owner

@all-contributors please add @vybhav72954 for documentation

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @vybhav72954! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing .gitignore?
3 participants