Skip to content

Sniffer in python #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 21, 2021
Merged

Sniffer in python #268

merged 11 commits into from
Jan 21, 2021

Conversation

pritamp17
Copy link
Contributor

@pritamp17 pritamp17 commented Jan 17, 2021 •
edited
Loading

Description

the script that can sniff HTTP pageg

Fixes #(246)

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings

@avinashkranjan avinashkranjan linked an issue Jan 17, 2021 that may be closed by this pull request
script that can sniff data from HTTP pages #246
Closed
atarax665
atarax665 reviewed Jan 17, 2021
View reviewed changes
Copy link
Contributor

@atarax665 atarax665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your code according to PEP8 Guidelines. You can use this.

SNIFFER/readme.md Outdated
@@ -0,0 +1,7 @@
# this script is created in python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you can come up with a better README. Have a look at READMEs of other contributed projects to get some idea.

SNIFFER/sniffer.py Outdated
# from scapy_http import http

def get_url(packet):
return packet[http.HTTPRequest].Host + packet[http.HTTPRequest].Path #for detecting urls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be above the code, not beside it.

Copy link
Contributor Author

@pritamp17 pritamp17 Jan 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sir, I have made changes, do I have to make any other changes?

@avinashkranjan avinashkranjan merged commit 8f7ed81 into avinashkranjan:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+1 more reviewer

@atarax665 atarax665 atarax665 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

script that can sniff data from HTTP pages
3 participants
@pritamp17 @atarax665 @avinashkranjan