Skip to content

Conversation

Bug-007
Copy link
Contributor

@Bug-007 Bug-007 commented Jan 27, 2021

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #302

Replace issue_no with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

Copy link
Contributor

@atarax665 atarax665 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add proper README according to this template.

@Bug-007
Copy link
Contributor Author

Bug-007 commented Jan 28, 2021

I have created README.md File and have included instructions.

@Bug-007
Copy link
Contributor Author

Bug-007 commented Jan 29, 2021

I have fixed that problem please, review it.

Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..🚀

@avinashkranjan
Copy link
Owner

@all-contributors please add @Bug-007 for code and documentation

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @Bug-007! 🎉

@avinashkranjan avinashkranjan merged commit b43c38e into avinashkranjan:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple Notepad
3 participants