Skip to content

Added the Shortest Path Finder gssoc'21 #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2021
Merged

Added the Shortest Path Finder gssoc'21 #499

merged 4 commits into from
Mar 14, 2021

Conversation

VishalPatil18
Copy link
Contributor

Description

Path-Finder is a Shortest Path Finding GUI application made with Pygame. It finds the shortest path between two points having some obstacles and thus avoiding them. It also shows the area of the board tracked to find the shortest path.

Fixes #496

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@VishalPatil18
Added the Shortest Path Finder (GUI)
9850a11
@VishalPatil18
Update README.md
f83f893 
Added the links to the Screenshots.
@VishalPatil18
Update README.md
195e75b 
Added the links to the Screenshots.
github-actions[bot]
github-actions bot reviewed Mar 11, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@kaustubhgupta
Copy link
Contributor

kaustubhgupta commented Mar 12, 2021 •
edited
Loading

Please review @santushtisharma10 @tamanna-verma @antrikshmisri as I don't have much experience in this algo. Ping me when it's ready to be merged, will assign the tags

antrikshmisri
antrikshmisri suggested changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@antrikshmisri antrikshmisri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpecTEviL Looks good , just handle this error which occurs at boundaries
Screenshot (162)

@VishalPatil18
Copy link
Contributor Author

@SpecTEviL Looks good , just add handle this error which occurs at boundaries
Screenshot (162)

Its not occurring in my local machine. Can you retry that? Or else elaborate on the error? @antrikshmisri

@VishalPatil18
Copy link
Contributor Author

VishalPatil18 commented Mar 13, 2021 •
edited
Loading

@SpecTEviL Looks good , just add handle this error which occurs at boundaries
Screenshot (162)

Also, can you recheck if it's my project only? Because the file you're running has a different name than mine. Mine had a name as "Shortest Path Finder.py". So just check that once and if the error occurs again do let me know. I'll debug it. @antrikshmisri
Thanks!

@antrikshmisri
Copy link
Contributor

@SpecTEviL Yes , it is your script just under different name. I think the problem is in your grid placement.


Screenshot (163)
As you can see near the black block there is still some space to place a block and as soon as I place a block there an IndexError is thrown

@santushtisharma10
Copy link
Contributor

@SpecTEviL I agree with @antrikshmisri .The problem is in your grid placement.

santushtisharma10
santushtisharma10 reviewed Mar 13, 2021
View reviewed changes
Shortest-Path-Finder (GUI)/Shortest Path Finder.py
Comment on lines 8 to 10

WIDTH = 600
WIN = pg.display.set_mode((WIDTH, WIDTH))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the width to the multiple of your rows(e.g. change the width to 595)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the width to the multiple of your rows(e.g. change the width to 595)

Sure I'll do it ASAP. Thanks for the suggestion.

@VishalPatil18
Copy link
Contributor Author

@SpecTEviL I agree with @antrikshmisri .The problem is in your grid placement.

@SpecTEviL I agree with @antrikshmisri .The problem is in your grid placement.

Ok, I'll debug it and get back to it.
Thank you @antrikshmisri and @santushtisharma10 for letting me know about this error.
I'll debug it ASAP!

@VishalPatil18
Update Shortest Path Finder.py
fc5d543 
Corrected the width of the Screen from 600 -> 595 to avoid the "List index out of range error" and making the grid symmetric.
@VishalPatil18
Copy link
Contributor Author

@SpecTEviL I agree with @antrikshmisri .The problem is in your grid placement.

@SpecTEviL I agree with @antrikshmisri .The problem is in your grid placement.

Ok, I'll debug it and get back to it.
Thank you @antrikshmisri and @santushtisharma10 for letting me know about this error.
I'll debug it ASAP!

Hey, @santushtisharma10 and @antrikshmisri I've made the required changes. You can review it now. If the error still persists do let me know.
Thanks!

@santushtisharma10
Copy link
Contributor

@antrikshmisri @tamanna-verma

antrikshmisri
antrikshmisri approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@antrikshmisri antrikshmisri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpecTEviL LGTM 🚀

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing labels Mar 13, 2021
@avinashkranjan avinashkranjan merged commit c96dbf5 into avinashkranjan:master Mar 14, 2021
@avinashkranjan
Copy link
Owner

@all-contributors please add @SpecTEviL for code and documentation

@allcontributors allcontributors bot mentioned this pull request Mar 14, 2021
Merged
@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @SpecTEviL! 🎉

@santushtisharma10 santushtisharma10 mentioned this pull request Mar 18, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+2 more reviewers

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shortest Path Finder.
5 participants
@VishalPatil18 @kaustubhgupta @antrikshmisri @santushtisharma10 @avinashkranjan