Skip to content

Conversation

NEERAJAP2001
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes #484

Replace issue_no with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

Copy link
Contributor

@antrikshmisri antrikshmisri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hardcoding the text and language take the inputs from the user. Also, I was not able to execute the code due to dependency issues. @kaustubhgupta @santushtisharma10 @tamanna-verma , can someone confirm if the code runs.

@NEERAJAP2001
Copy link
Contributor Author

Alright, @antrikshmisri changes coming up !!

Also, I was not able to execute the code due to dependency issues.

Please read the documentation, I've mentioned dependencies there!
Thanks

@antrikshmisri
Copy link
Contributor

Alright, @antrikshmisri changes coming up !!

Also, I was not able to execute the code due to dependency issues.

Please read the documentation, I've mentioned dependencies there!
Thanks

@NEERAJAP2001 I meant I wasn't able to run the code with the mentioned dependencies on my local machine

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Mar 14, 2021
@NEERAJAP2001
Copy link
Contributor Author

Screenshot (254)

@kaustubhgupta Works Fine!!

@kaustubhgupta
Copy link
Contributor

kaustubhgupta commented Mar 14, 2021

@antrikshmisri @santushtisharma10 approval awaited

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Mar 14, 2021
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Mar 14, 2021
@avinashkranjan avinashkranjan merged commit 814408b into avinashkranjan:master Mar 14, 2021
@avinashkranjan
Copy link
Owner

@all-contributors please add @NEERAJAP2001 for code and documentation

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @NEERAJAP2001! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translator Script in Python
5 participants