Face mask #630
Face mask #630
Conversation
There was a problem hiding this comment.
Just a few modifications before merging:
- Add a section in readme named "Setup Instructions" where describe that extract the dataset.rar and how to run the script.
- Update all the paths in script as shown below in example:
testing_target=data_set('./Face-Mask-Detection/kaggle/input/face-mask-detection/test/')- Shift all the relevant import statements on top
kaustubhgupta
added
the
minor-change-not-bug
|
I have made the necessary changes. Please review it. |
| from sklearn.metrics import classification_report | ||
| import sklearn.metrics as metrics | ||
| import itertools | ||
| for dirname, _, filenames in os.walk('/kaggle/input'): |
There was a problem hiding this comment.
This path also needs modification
| data = np.array(data, dtype="float") / 255.0 | ||
| target = tf.keras.utils.to_categorical(np.array(target), num_classes=2) | ||
| return data, target | ||
| training_target=data_set('./Face-Mask-Detection/kaggle/input/face-mask-detection/train/') |
There was a problem hiding this comment.
What do you want to load here? There is no extension to files. Same for next testing_target and valid_target. Also, where are the testing_data, training_data, and valid_data variables? They are not initialized anywhere but passed into functions.
There was a problem hiding this comment.
@kaustubhgupta I think he is specifying the file here , I could be wrong as I haven't run this code yet
There was a problem hiding this comment.
Actually the pylint test gave these errors and when I saw the script, I found these variables are missing but passed in functions
There was a problem hiding this comment.
@kaustubhgupta Yup , the linter is giving error because of undefined variables. I am referring to the training_target variable , he is taking directory as argument to data_set function and then appending file name here.
There was a problem hiding this comment.
What do you want to load here? There is no extension to files. Same for next testing_target and valid_target. Also, where are the testing_data, training_data, and valid_data variables? They are not initialized anywhere but passed into functions.
extension is not required, because they are folders and they will directly have access to the files within them.
kaustubhgupta
added
bug
|
What should I do ? |
all the suggestions are mentioned above |
|
I have done the changes, please do review |
|
@antrikshmisri I ran the script but it didn't work. What should we do? |
@kaustubhgupta I am unable to get some dependencies so , couldn't test it. @santushtisharma10 Can you confirm the same |
|
I need to do something ? |
|
@antrikshmisri @kaustubhgupta facing following error while running the script |
@sudipg4112001 Can you guide how to fix this? Is the script running on your machine? Can you share any GIF, video as Proof? |
kaustubhgupta
added
hold
|
Yes, this same code is running smoothly in my device. I am confused what's the problem with yours. I am attaching a screenshot below.
After making the changes you suggested it's now running smoothly. |
As he has shown this screenshot, should we approve this? @antrikshmisri @santushtisharma10 |
@kaustubhgupta @santushtisharma10 Okay from my side but I think we should refer @avinashkranjan first. |
Yes, that makes sense |
|
Updates: Conveyed the message to PA, he will respond soon |
|
The Scripts Seems to working for me.. I Just Commented out line 39..And the Script works fine for me So, I'm approving the Script..Make the required changes in line 39, Else Remove it..Will Merge it then |
|
I have made the changes.. |
|
Do review |
|
@sudipg4112001 Don't Spam the Comments..Will Review it in Sometime.. |
avinashkranjan
added
Approved
5 participants
Related Issue
Fixes #510