Skip to content

Feature/covid stats #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 25, 2021
Merged

Feature/covid stats #672

merged 8 commits into from
Mar 25, 2021

Conversation

dsg1320
Copy link
Contributor

@dsg1320 dsg1320 commented Mar 19, 2021 •
edited
Loading

Description

This project uses an external API for getting the stats of COVID in Indian states

Fixes #18

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

github-actions[bot]
github-actions bot reviewed Mar 19, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

kaustubhgupta
kaustubhgupta approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @dsg1320 💯 🥇

@kaustubhgupta kaustubhgupta added the next review needed Approved by some mentors, more approvals needed label Mar 20, 2021
@dsg1320
Copy link
Contributor Author

dsg1320 commented Mar 20, 2021 via email

@kaustubhgupta
Copy link
Contributor

@antrikshmisri @santushtisharma10

santushtisharma10
santushtisharma10 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsg1320 💯

@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels Mar 22, 2021
@avinashkranjan avinashkranjan merged commit e41b2c3 into avinashkranjan:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+3 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facebook messenger bot to get COVID statistics
5 participants
@dsg1320 @kaustubhgupta @antrikshmisri @avinashkranjan @santushtisharma10