Skip to content

Update temp_sign_up_tool.py #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

Update temp_sign_up_tool.py #678

merged 1 commit into from
Mar 25, 2021

Conversation

chaitanyabisht
Copy link
Contributor

@chaitanyabisht chaitanyabisht commented Mar 20, 2021 •
edited by kaustubhgupta
Loading

Description

The website is opened now when the link is clicked...Previously it did not open any webpage

Fixes #679

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@chaitanyabisht
Update temp_sign_up_tool.py
05881d3 
The website is opened now when the link is clicked...Previously it did not open any webpage
github-actions[bot]
github-actions bot reviewed Mar 20, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@kaustubhgupta kaustubhgupta added hold Needs a second thought question Further information is requested and removed hold Needs a second thought question Further information is requested labels Mar 20, 2021
@kaustubhgupta kaustubhgupta added the next review needed Approved by some mentors, more approvals needed label Mar 20, 2021
@kaustubhgupta
Copy link
Contributor

@antrikshmisri

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants Level0 Minor Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Mar 22, 2021
@avinashkranjan avinashkranjan merged commit 9edc526 into avinashkranjan:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

+3 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants Level0 Minor Documentation Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking the hyperlink in Temporary-Sign-Up-Tool
5 participants
@chaitanyabisht @kaustubhgupta @antrikshmisri @santushtisharma10 @avinashkranjan