Skip to content

LinkedIn Connections Scrapper #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2021
Merged

LinkedIn Connections Scrapper #698

merged 4 commits into from
Mar 25, 2021

Conversation

XZANATOL
Copy link
Contributor

Description

Added LinkedIn Connections Scrapper.

Notes

  1. I've added script output files of my LinkedIn small connections list here. (Skills column not Included.)
  2. For the skills scrapping, I've extracted the function responsible for this work and tried it alone on my LinkedIn profile. Results can be viewed here

Fixes #56

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

kaustubhgupta
kaustubhgupta suggested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor corrections, else the script works great

Linkedin_Connections_Scrapper/ReadMe.md Outdated

Mentored by [Avinash Kr. Ranjan](https://github.com/avinashkranjan).

Reviewed by [Kaustubh Gupta](https://github.com/kaustubhgupta).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will be reviewed by other mentors too so it would be unfair for them. You can remove this line

Linkedin_Connections_Scrapper/script.py Outdated
@@ -0,0 +1,192 @@
# Linkedin My_Connections Scrapper
# Written by XZANATOL
# Mentored by avinashkranjan & kaustubhgupta / GSSOC'21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier :-)

@kaustubhgupta kaustubhgupta added the minor-change-not-bug Suggested a minor change in code, not a bug label Mar 22, 2021
@XZANATOL
Copy link
Contributor Author

@kaustubhgupta Done.

kaustubhgupta
kaustubhgupta approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XZANATOL great job again 💯 😃

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Mar 22, 2021
antrikshmisri
antrikshmisri suggested changes Mar 22, 2021
View reviewed changes
Linkedin_Connections_Scrapper/script.py
parser.add_option("-s", "--skills", action="store_true", dest="skills", help="Flag to scrap each profile, and look at its skill set")


def login(email, password):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some logic to verify if user was logged in or not. You can do that by either looking for the error message or by checking the page title by using driver.title

@XZANATOL
Copy link
Contributor Author

@antrikshmisri Done.

antrikshmisri
antrikshmisri approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@antrikshmisri antrikshmisri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now 💯

@kaustubhgupta
Copy link
Contributor

@santushtisharma10

@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels Mar 25, 2021
avinashkranjan
avinashkranjan approved these changes Mar 25, 2021
View reviewed changes
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..Great job @XZANATOL

@avinashkranjan avinashkranjan merged commit a8026c4 into avinashkranjan:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+3 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script to scrap LinkedIn Connections details
5 participants
@XZANATOL @kaustubhgupta @antrikshmisri @avinashkranjan @santushtisharma10