Skip to content

Conversation

sarthak1905
Copy link
Contributor

Description

Added project with 4 files- a python script consisting of the program, a README.md consisting of the instructions, details and other relevant information, a screenshot as proof of working code and a requirements.txt consisting of all the dependencies required.

Fixes #70

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations!! for making your first PR at Amazing-Python-Scripts, our mentors will review it soon.

@avinashkranjan avinashkranjan self-requested a review October 5, 2020 06:19
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..💯.. Great Job @sarthak1905

@avinashkranjan avinashkranjan merged commit 70c3986 into avinashkranjan:master Oct 5, 2020
@avinashkranjan
Copy link
Owner

@all-contributors please add @sarthak1905 for code and documentation

@allcontributors
Copy link
Contributor

@avinashkranjan

I've put up a pull request to add @sarthak1905! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Amazon web-scraper
2 participants