Pdf2Text #736

Amit366 · 2021-03-25T07:10:51Z

Description

Converts a pdf file to text file

Fixes #608

Have you read the Contributing Guidelines on Pull Requests?

Yes

Kushal997-das

@Amit366 if i put my path like the below it will give me the error . It occurs because i used This a normal string as a path. To overcome this just put r before your normal string it converts normal string to raw string. So change this so that everyone can use your project .

Moreover , there could be more error i think . Please @kaustubhgupta check this carefully thank you :)

Amit366 · 2021-03-25T08:10:17Z

@Kushal997-das on running the script it asks the user to enter the url. But as I can see you have changed input part.

kaustubhgupta

Why there are flappy bird game files in this PR?

Amit366 · 2021-03-25T09:01:30Z

@kaustubhgupta I am really sorry

Amit366 · 2021-03-25T09:01:38Z

I will remove that

kaustubhgupta · 2021-03-25T09:02:42Z

I will remove that

Don't remove them one by one. Just delete this branch, and create new PR from new branch

Amit366 · 2021-03-25T09:03:59Z

@kaustubhgupta I already deleted and also commited it

Kushal997-das · 2021-03-25T11:20:35Z

@Kushal997-das on running the script it asks the user to enter the url . But as I can see you have changed input part.

It doesn't matter if you give input runtime or not it gives you same error as same input .

Kushal997-das · 2021-03-25T11:36:33Z

@Kushal997-das on running the script it asks the user to enter the url . But as I can see you have changed input part.

It doesn't matter if you give input runtime or not it gives you same error as same input .

@Kushal997-das in run time it doesn't give the error

Could You please make a demo video of it ? And moreover in worst case scenario your program should run in both cases .

Amit366 · 2021-03-25T11:39:00Z

@Kushal997-das I made the changes

Kushal997-das · 2021-03-25T18:14:53Z

@Kushal997-das I made the changes

@Amit366 Yeah i saw . @kaustubhgupta Could you please run this code in your local because in my system this program is not working properly .

Amit366 · 2021-03-25T18:20:00Z

@Kushal997-das is it showing any error??

kaustubhgupta · 2021-03-26T07:02:32Z

PDF2Text/Readme.md

+
+    Sit back and Relax. Let the Script do the Job. ☕
+
+### Requirements


Suggested change

### Requirements

## Requirements

PDF2Text/script.py

kaustubhgupta · 2021-03-26T07:07:11Z

PDF2Text/script.py

+
+    st += page.getPage(i).extractText()
+
+with open('./PDF2Text/pages/text.txt','w') as f:


This will not work as there is no folder named "pages".

Amit366 · 2021-03-26T07:34:10Z

@kaustubhgupta made the changes

kaustubhgupta

No text gets extracted from PDFs. Only blank test files were generated. Test the script locally and fix the bugs.

Kushal997-das · 2021-03-27T05:12:46Z

No text gets extracted from PDFs. Only blank test files were generated. Test the script locally and fix the bugs.

Same problem i also faced @kaustubhgupta

Amit366 · 2021-03-27T05:28:22Z

@kaustubhgupta it's working fine for me

Amit366 · 2021-03-27T05:29:08Z

@kaustubhgupta do I thing. Place the PDF file into the script folder. Then try once.

kaustubhgupta · 2021-03-27T05:32:07Z

@kaustubhgupta do I thing. Place the PDF file into the script folder. Then try once.

It's not about the path, it' about: no text was present in the files. I tested this for my resume, the document with text only

Amit366 · 2021-03-27T05:33:53Z

@kaustubhgupta then how is it working for me

Amit366 · 2021-03-27T05:34:09Z

I will send the pics.

kaustubhgupta · 2021-03-27T05:35:15Z

No text gets extracted from PDFs. Only blank test files were generated. Test the script locally and fix the bugs.

Same problem i also faced @kaustubhgupta

I am not the only one @Amit366

Kushal997-das · 2021-03-27T05:35:44Z

I will send the pics.

Send one gif of this even in my case i faced same problem .

Amit366 · 2021-03-27T05:51:08Z

Amit366 · 2021-03-27T05:51:48Z

kaustubhgupta · 2021-03-27T06:10:44Z

@Amit366 Okay got it. Include these Screenshots in the readme file too. Name that section: "Expected Output"

Amit366 · 2021-03-27T06:22:10Z

@kaustubhgupta I have placed the pics into the readme

Amit366 · 2021-03-27T09:04:35Z

@kaustubhgupta please review it.

kaustubhgupta

Images not rendered:

Amit366 · 2021-03-27T14:53:49Z

@kaustubhgupta please review it

Kushal997-das

LGTM

Amit366 · 2021-03-28T10:57:59Z

@kaustubhgupta it was a level 2 issue but it is given level 1. Please check.

Amit366 · 2021-03-29T09:41:59Z

@kaustubhgupta can u please check the level

kaustubhgupta · 2021-03-29T10:48:46Z

@kaustubhgupta can u please check the level

Yes, the level was initially 2 but as you submitted the code, 3 days ago, we changed it to level 1 as the code doesn't work for all types of files plus the Code Quality was not up to level2

Amit366 · 2021-03-29T10:58:53Z

@kaustubhgupta if the script is run in Vs code it will run fine .Once try it out, it works for all types of files (pdf files)

Amit366 added 2 commits March 23, 2021 21:07

Flappy bird game

ed100fa

PDF2Text

89b45e2

Kushal997-das suggested changes Mar 25, 2021

View reviewed changes

kaustubhgupta suggested changes Mar 25, 2021

View reviewed changes

kaustubhgupta added the bug Something isn't working label Mar 25, 2021

Removed

93fd442

Updated

c7939e1

kaustubhgupta suggested changes Mar 26, 2021

View reviewed changes

Changes

d1c21ba

kaustubhgupta suggested changes Mar 27, 2021

View reviewed changes

Updated Readme

a68ece2

kaustubhgupta suggested changes Mar 27, 2021

View reviewed changes

kaustubhgupta added minor-change-not-bug Suggested a minor change in code, not a bug and removed bug Something isn't working labels Mar 27, 2021

Update

6ebc12f

kaustubhgupta approved these changes Mar 28, 2021

View reviewed changes

kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Mar 28, 2021

kaustubhgupta requested review from antrikshmisri and santushtisharma10 March 28, 2021 03:36

antrikshmisri approved these changes Mar 28, 2021

View reviewed changes

santushtisharma10 approved these changes Mar 28, 2021

View reviewed changes

santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Mar 28, 2021

Kushal997-das approved these changes Mar 28, 2021

View reviewed changes

avinashkranjan approved these changes Mar 30, 2021

View reviewed changes

avinashkranjan merged commit c4e0720 into avinashkranjan:master Mar 30, 2021


		Sit back and Relax. Let the Script do the Job. ☕

		### Requirements


		st += page.getPage(i).extractText()

		with open('./PDF2Text/pages/text.txt','w') as f:

Uh oh!

Pdf2Text #736

Pdf2Text #736

Uh oh!

Conversation

Amit366 commented Mar 25, 2021

Description

Fixes #608

Have you read the Contributing Guidelines on Pull Requests?

Uh oh!

Kushal997-das left a comment

Choose a reason for hiding this comment

Uh oh!

Amit366 commented Mar 25, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Amit366 commented Mar 25, 2021

Uh oh!

Amit366 commented Mar 25, 2021

Uh oh!

kaustubhgupta commented Mar 25, 2021

Uh oh!

Amit366 commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kushal997-das commented Mar 25, 2021

Uh oh!

Kushal997-das commented Mar 25, 2021

Uh oh!

Amit366 commented Mar 25, 2021

Uh oh!

Kushal997-das commented Mar 25, 2021

Uh oh!

Amit366 commented Mar 25, 2021

Uh oh!

kaustubhgupta Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaustubhgupta Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

Amit366 commented Mar 26, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Kushal997-das commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

kaustubhgupta commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

kaustubhgupta commented Mar 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kushal997-das commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

kaustubhgupta commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

Amit366 commented Mar 27, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Amit366 commented Mar 27, 2021

Amit366 commented Mar 25, 2021 •

edited

Loading

kaustubhgupta commented Mar 27, 2021 •

edited

Loading

Amit366 commented Mar 29, 2021 •

edited

Loading