Skip to content

Added video to audio converter g UI #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 30, 2021
Merged

Added video to audio converter g UI #742

merged 6 commits into from
Mar 30, 2021

Conversation

amrzaki2000
Copy link
Contributor

Description

Created a Video to Audio converter with GUI

Fixes #321

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@amrzaki2000
Copy link
Contributor Author

@kaustubhgupta @avinashkranjan
Hello,
I'm so sorry for late pull request.
My spring semester began last Sunday and I was so busy and distracted. I'm sorry again.
Thank you

kaustubhgupta
kaustubhgupta suggested changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script doesn't work. Also, if possible, can you implement a progress bar while converting?:

image

Video-Audio-Converter-GUI/README.md Outdated
@@ -0,0 +1,16 @@
# Welcome
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace welcome with script name

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Mar 26, 2021
@amrzaki2000
Copy link
Contributor Author

@kaustubhgupta
Sure I'll add it.

Can you tell me when the error appeared ?

@amrzaki2000
Copy link
Contributor Author

amrzaki2000 commented Mar 26, 2021 •
edited
Loading

@kaustubhgupta
I could not find a way that can keep track of the progress of the function write_audiofile used to create the audio file. So, I created a more like loading bar that keeps running concurrently with save_audio_file function and stops when the function finishes execution.

Can you try the script now and tell me if it is not still running, please ?
It is working on my machine.

kaustubhgupta
kaustubhgupta approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, @amrzaki2000! The moving progress bar is a great way to show progress. And the script is now working. Good Job 💯

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Mar 27, 2021
@kaustubhgupta
Copy link
Contributor

@Kushal997-das

Kushal997-das
Kushal997-das suggested changes Mar 27, 2021
View reviewed changes
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the white spaces @amrzaki2000

santushtisharma10
santushtisharma10 approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrzaki2000 💯

@amrzaki2000
Copy link
Contributor Author

Remove the white spaces @amrzaki2000

Ok

@amrzaki2000
Copy link
Contributor Author

@Kushal997-das Done

Kushal997-das
Kushal997-das approved these changes Mar 27, 2021
View reviewed changes
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 💯

@santushtisharma10
Copy link
Contributor

@antrikshmisri

@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels Mar 28, 2021
avinashkranjan
avinashkranjan approved these changes Mar 30, 2021
View reviewed changes
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinashkranjan avinashkranjan merged commit f7bacf6 into avinashkranjan:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+4 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

@Kushal997-das Kushal997-das Kushal997-das approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Video to Audio Converter GUI
6 participants
@amrzaki2000 @kaustubhgupta @santushtisharma10 @antrikshmisri @avinashkranjan @Kushal997-das