🚀Added Gmplot #745

Lakhankumawat · 2021-03-26T10:16:19Z

Description

Tracking the route of a person OR Tracking a specific path followed by a person

Gmplot Can be used to plot the coordinates on Google map .
These coordinates can be imported from a fixed CSV file that doesn't change OR can be taken as input from user in Latitude and Longitude format .

Fixes #713

Have you read the Contributing Guidelines on Pull Requests?

Yes
No

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines(Clean Code) of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have created a helpful and easy to understand README.md
My documentation follows Template for README.md
My changes generate no new warnings
I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Lakhankumawat · 2021-03-26T10:33:49Z

For any modifications let me know .

kaustubhgupta

upload the CSV used in the script. Implement these changes too:

kaustubhgupta · 2021-03-27T05:20:38Z

Gmplot-Track the Route/README.md

+    37.766227, -122.460213
+    37.764028, -122.510347
+
+ # Author 


Suggested change

# Author

# Author

I got to changes which are requested but i have some doubts

Do i remove author name from README / I mean i didn't get above review.

Rest else is fine i will take file address as an input form user .

No, You can keep the author name, no issues, I was suggesting to remove the space with (#) and line start as the Author level was not rendered properly.

kaustubhgupta · 2021-03-27T05:21:40Z

Gmplot-Track the Route/main.py

+gmap = gmplot.GoogleMapPlotter(20.613456, 72.9431185,17) #Plotting data on map
+#gmap.coloricon="https://developers.google.com/maps/documentation/javascript/examples/full/images/beachflag.png"
+
+with open('Home/MyPC/Python/LatLong.csv','r') as f:  #give the address of csv file with respect to your folder containing .py file


ask the user to input the file path

Requested changes are made .

Modified author's name in readme , removed unnecessary spaces

kaustubhgupta · 2021-03-27T10:47:34Z

Gmplot-Track the Route/README.md

+    37.766227, -122.460213
+    37.764028, -122.510347
+
+### Author : [Lakhan Kumawat](https://github.com/Lakhankumawat)


Suggested change

### Author : [Lakhan Kumawat](https://github.com/Lakhankumawat)

## Author : [Lakhan Kumawat](https://github.com/Lakhankumawat)

If i remove one # then size will be too big and it looks unusual .
If you say so i can remove .

can remove this, we need to follow a consistent pattern

kaustubhgupta · 2021-03-27T10:48:03Z

Gmplot-Track the Route/main.py

@@ -0,0 +1,24 @@
+


upload the CSV to be used in the script for testing

I think my code has some bugs i will resolve them in a day or two and will notify you.

Okay, make sure to update it by tomorrow

Actually i m out of town these days i will be back in 3 days so it would be great sir if you wait , please

Oh okay, I will put the hold label for now.

Lakhankumawat · 2021-03-30T07:17:39Z

I think now it looks fine , mentors please have a look

Code Works Properly
CSV file added / Clarification
Output Screenshot added in README

kaustubhgupta

You have not done something new here: https://pypi.org/project/gmplot/. Only the coordinates loading is changed from zipping to pandas data frame. This being level2 issue needs modifications. Suggestions:

Add some more coordinates, Indian coordinates of around 100 places.
Here: gmplot.GoogleMapPlotter(37.771260, -122.511011,17), take input for zoom level and for central coordinates, take the average of all the coordinates for x and y separately.

Lakhankumawat · 2021-03-31T05:48:25Z

You have not done something new here: https://pypi.org/project/gmplot/. Only the coordinates loading is changed from zipping to pandas data frame. This being level2 issue needs modifications. Suggestions:

Add some more coordinates, Indian coordinates of around 100 places.

Here: gmplot.GoogleMapPlotter(37.771260, -122.511011,17), take input for zoom level and for central coordinates, take the average of all the coordinates for x and y separately.

Requested Changes are made

For now i haven't modified README screenshot , waiting for @kaustubhgupta sir to verify changes after that i will modify it.
Code works fine
100 Coordinates added
Average Taken in x and y
Zoom is taken as input

Lakhankumawat · 2021-04-01T05:39:35Z

Also i could have added polygon just like in the link you mentioned but it would have been lot more cluttering with 100 coordinates

kaustubhgupta · 2021-04-01T05:43:42Z

You have not done something new here: https://pypi.org/project/gmplot/. Only the coordinates loading is changed from zipping to pandas data frame. This being level2 issue needs modifications. Suggestions:

Add some more coordinates, Indian coordinates of around 100 places.

Here: gmplot.GoogleMapPlotter(37.771260, -122.511011,17), take input for zoom level and for central coordinates, take the average of all the coordinates for x and y separately.

Requested Changes are made

For now i haven't modified README screenshot , waiting for @kaustubhgupta sir to verify changes after that i will modify it.

Code works fine

100 Coordinates added

Average Taken in x and y

Zoom is taken as input

This looks good. You can make the changes in the PR

Lakhankumawat · 2021-04-01T07:43:09Z

Updated README request a review from other members please if it is good to go.
For modifications let me know

kaustubhgupta · 2021-04-01T11:32:50Z

Gmplot-Track the Route/README.md

+| ------ | ------ |
+| `pip install gmplot` | [Gmplot/PyPI](https://pypi.org/project/gmplot/) |
+
+# CSV File Data


Now you can remove this section and corresponding lat-long values

kaustubhgupta · 2021-04-01T11:34:04Z

@Kushal997-das

avinashkranjan

LGTM..

Added Gmplot

8563924

kaustubhgupta suggested changes Mar 27, 2021

View reviewed changes

kaustubhgupta added the bug Something isn't working label Mar 27, 2021

Lakhankumawat added 2 commits March 27, 2021 13:25

Update README

f6cfbff

Modified author's name in readme , removed unnecessary spaces

Update main.py

bab120c

Lakhankumawat requested a review from kaustubhgupta March 27, 2021 08:00

kaustubhgupta suggested changes Mar 27, 2021

View reviewed changes

kaustubhgupta added the hold Needs a second thought label Mar 28, 2021

Lakhankumawat added 3 commits March 30, 2021 12:42

Update main.py

466b983

Update README.md

7389587

Add CSV file

6c9c50b

Lakhankumawat requested a review from kaustubhgupta March 30, 2021 07:18

kaustubhgupta suggested changes Mar 31, 2021

View reviewed changes

kaustubhgupta removed the hold Needs a second thought label Mar 31, 2021

Lakhankumawat added 2 commits March 31, 2021 11:13

Update main.py

1dcce19

Update LatLong.csv

12a545c

Lakhankumawat requested a review from kaustubhgupta March 31, 2021 05:48

Update README.md

640be4c

kaustubhgupta approved these changes Apr 1, 2021

View reviewed changes

kaustubhgupta requested review from antrikshmisri and santushtisharma10 April 1, 2021 11:34

Changes made

5484ec6

kaustubhgupta removed the bug Something isn't working label Apr 1, 2021

kaustubhgupta added the next review needed Approved by some mentors, more approvals needed label Apr 1, 2021

antrikshmisri approved these changes Apr 2, 2021

View reviewed changes

santushtisharma10 approved these changes Apr 2, 2021

View reviewed changes

kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features and removed next review needed Approved by some mentors, more approvals needed labels Apr 3, 2021

avinashkranjan approved these changes Apr 4, 2021

View reviewed changes

avinashkranjan merged commit d7288b5 into avinashkranjan:master Apr 4, 2021

	### Author : [Lakhan Kumawat](https://github.com/Lakhankumawat)
	## Author : [Lakhan Kumawat](https://github.com/Lakhankumawat)

Uh oh!

🚀Added Gmplot #745

🚀Added Gmplot #745

Uh oh!

Conversation

Lakhankumawat commented Mar 26, 2021

Description

Fixes #713

Have you read the Contributing Guidelines on Pull Requests?

Type of change

Checklist:

Uh oh!

Lakhankumawat commented Mar 26, 2021

Uh oh!

kaustubhgupta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lakhankumawat Mar 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

I got to changes which are requested but i have some doubts

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Requested changes are made .

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lakhankumawat commented Mar 30, 2021

Uh oh!

kaustubhgupta left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lakhankumawat commented Mar 31, 2021

Requested Changes are made

Uh oh!

Lakhankumawat commented Apr 1, 2021

Uh oh!

kaustubhgupta commented Apr 1, 2021

Requested Changes are made

Uh oh!

Lakhankumawat commented Apr 1, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaustubhgupta commented Apr 1, 2021

Uh oh!

avinashkranjan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lakhankumawat Mar 27, 2021 •

edited

Loading

kaustubhgupta left a comment •

edited

Loading