Skip to content

Conversation

Amit366
Copy link
Contributor

@Amit366 Amit366 commented Mar 29, 2021

Description

Zipped files are converted to unzipped files

Fixes #651

Have you read the Contributing Guidelines on Pull Requests?

Yes

@Amit366
Copy link
Contributor Author

Amit366 commented Mar 29, 2021

Screenshot (133)_LI

@Amit366
Copy link
Contributor Author

Amit366 commented Mar 29, 2021

Screenshot (134)

@kaustubhgupta this is the working model

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is working. Readme update:


## Unzip File Functionalities : 🚀

- First upload the stocks dataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is from previous PRs. Fix this

@kaustubhgupta kaustubhgupta added the minor-change-not-bug Suggested a minor change in code, not a bug label Mar 30, 2021
@Amit366
Copy link
Contributor Author

Amit366 commented Mar 30, 2021

@kaustubhgupta fixed

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Mar 31, 2021
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Mar 31, 2021
@avinashkranjan
Copy link
Owner

@Amit366 Resolve the conflict

@avinashkranjan avinashkranjan removed the Approved PR Approved and Ready to Merge label Mar 31, 2021
@kaustubhgupta kaustubhgupta added the Approved PR Approved and Ready to Merge label Apr 1, 2021
@avinashkranjan avinashkranjan merged commit c1870d1 into avinashkranjan:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unzip a File

6 participants