Skip to content

Terminal Hangman #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 10, 2021
Merged

Terminal Hangman #796

merged 8 commits into from
Apr 10, 2021

Conversation

Yuvraj-kadale
Copy link
Contributor

Description

Added Terminal Hangman

Fixes #793

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

kaustubhgupta
kaustubhgupta suggested changes Apr 2, 2021
View reviewed changes
@kaustubhgupta kaustubhgupta added the minor-change-not-bug Suggested a minor change in code, not a bug label Apr 2, 2021
kaustubhgupta
kaustubhgupta suggested changes Apr 3, 2021
View reviewed changes
@Yuvraj-kadale @kaustubhgupta
Update Terminal Hangman/T_hangman.py
e002080 
Co-authored-by: Kaustubh Gupta <kaustubhgupta1828@gmail.com>
@Yuvraj-kadale
Copy link
Contributor Author

@kaustubhgupta btw both .txt and .py files are in same folder .. and the code was working.

santushtisharma10
santushtisharma10 approved these changes Apr 4, 2021
View reviewed changes
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yuvraj-kadale 💯

@santushtisharma10 santushtisharma10 added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Apr 4, 2021
@santushtisharma10
Copy link
Contributor

@Kushal997-das

@santushtisharma10
Copy link
Contributor

@antrikshmisri @Kushal997-das

@santushtisharma10 santushtisharma10 added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Apr 6, 2021
avinashkranjan
avinashkranjan approved these changes Apr 10, 2021
View reviewed changes
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinashkranjan avinashkranjan merged commit e7d2a17 into avinashkranjan:master Apr 10, 2021
@Yuvraj-kadale Yuvraj-kadale deleted the hangman branch May 6, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+3 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hangman on terminal
5 participants
@Yuvraj-kadale @santushtisharma10 @kaustubhgupta @antrikshmisri @avinashkranjan