Skip to content

TicTacToe-GUI using Pygame 🐍 #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2021
Merged

TicTacToe-GUI using Pygame 🐍 #851

merged 5 commits into from
Apr 19, 2021

Conversation

Lakhankumawat
Copy link
Contributor

Description

Added Tic Tac Toe game using GUI

  1. Making a GUI with pygame lib.
  2. Building Game Logic .
  3. Drawing squares and circles where ever player clicks.
  4. Implementing
  5. Playing

Details

Libraries Used : pygame , numpy , sys

Fixes #768

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@Lakhankumawat Lakhankumawat changed the title TicTacToe-GUI using Pygame TicTacToe-GUI using Pygame 🐍 Apr 8, 2021
santushtisharma10
santushtisharma10 suggested changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lakhankumawat display player 1 and player 2 turns while playing game. When the game ends display the results of game like which player has won or the result is tie. After the game ends add an option to restart or exit the game

@santushtisharma10 santushtisharma10 added the enhancement New feature or request label Apr 9, 2021
@Lakhankumawat
Copy link
Contributor Author

Okay i will work on requested changes.

@Lakhankumawat
Copy link
Contributor Author

snip

Sir Requested Changes are made . Try to run it on your local machine code works fine. For further changes let me know .

@Lakhankumawat
Copy link
Contributor Author

Please Ignore first commit consider second one which is just now .
First Commit had some issues
All requested changes are solved except one

Tie is not detected even if you see i have commited somewhere to check a tie but it's not working rest everything works fine.

@Lakhankumawat
Copy link
Contributor Author

No replies from @santushtisharma10 ma'am since 2 days @kaustubhgupta sir please have a look

kaustubhgupta
kaustubhgupta suggested changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug:

When the game is a draw nothing happens:
image

TicTacToe-GUI/TicTacToe.py Outdated
import pygame, sys
from pygame.locals import *
import numpy as np
#import WorkingModal as Wp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Ignore first commit consider second one which is just now .
First Commit had some issues
All requested changes are solved except one

Tie is not detected even if you see i have commited somewhere to check a tie but it's not working rest everything works fine.

Yeah i mentioned it here i will try removing this bug.

@kaustubhgupta kaustubhgupta added bug Something isn't working and removed enhancement New feature or request labels Apr 14, 2021
@Lakhankumawat
Copy link
Contributor Author

ss

Looks Fine!!

@santushtisharma10
Copy link
Contributor

@Lakhankumawat apologies. Was busy with other some stuff. Will review it shortly

@Lakhankumawat
Copy link
Contributor Author

@Lakhankumawat apologies. Was busy with other some stuff. Will review it shortly

Okay no problems you guys already seemingly work hard to merge everyone's PR understanding them and reviewing it's not simple . Take your time

kaustubhgupta
kaustubhgupta approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Apr 15, 2021
santushtisharma10
santushtisharma10 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @Lakhankumawat 💯💯

antrikshmisri
antrikshmisri suggested changes Apr 15, 2021
View reviewed changes
TicTacToe-GUI/TicTacToe.py Outdated
Won= font.render("Player"+str(player)+" Turn ", True ,blue,green)
screen.blit(Won, winRect)
draw_figures()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra blank lines

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lakhankumawat Please make these changes so that we can move your PR to PA

@kaustubhgupta kaustubhgupta mentioned this pull request Apr 17, 2021
Closed
@kaustubhgupta kaustubhgupta removed the next review needed Approved by some mentors, more approvals needed label Apr 17, 2021
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features labels Apr 17, 2021
avinashkranjan
avinashkranjan approved these changes Apr 19, 2021
View reviewed changes
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..🚩

@avinashkranjan avinashkranjan merged commit b7662b9 into avinashkranjan:master Apr 19, 2021
@Lakhankumawat Lakhankumawat deleted the TicTacToe-GUI branch March 13, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+3 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tic Tac Toe game with GUI using Pygame in Python
5 participants
@Lakhankumawat @santushtisharma10 @kaustubhgupta @antrikshmisri @avinashkranjan