Corona cases Time series forecasting #828 #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kaustubhgupta
suggested changes
Apr 9, 2021
corona cases forecasting/README.md
Outdated
| @@ -0,0 +1,17 @@ | |||
| # corona Cases Forecasting | |||
There was a problem hiding this comment.
Suggested change
| # corona Cases Forecasting | |
| # Corona Cases Forecasting |
corona cases forecasting/main.py
Outdated
|
|
||
|
|
||
|
|
||
| def recovered_cases(): |
There was a problem hiding this comment.
Here is the error, you previously defined the "recovered_cases" as a pandas data frame and now defining it as a function. This may not have any effect in Jupyter notebook as they are cell-based but in a Py script, it will give an error. Change this function name and at other instances where it is used
kaustubhgupta
added
bug
kaustubhgupta
suggested changes
Apr 10, 2021
corona cases forecasting/main.py
Outdated
| plt.title('New active Cases Forecast') | ||
| plt.xticks(rotation=90) | ||
| # plt.figure(figsize=(22,22)) | ||
| plt.savefig("plot1.png",bbox_inches='tight') |
There was a problem hiding this comment.
Suggested change
| plt.savefig("plot1.png",bbox_inches='tight') | |
| plt.savefig("./corona cases forecasting/Results/plot1.png",bbox_inches='tight') | |
corona cases forecasting/main.py
Outdated
| plt.title('New death Cases Forecast') | ||
| plt.xticks(rotation=90) | ||
| # plt.figure(figsize=(22,22)) | ||
| plt.savefig("plot2.png",bbox_inches='tight') |
There was a problem hiding this comment.
Suggested change
| plt.savefig("plot2.png",bbox_inches='tight') | |
| plt.savefig("./corona cases forecasting/Results/plot2.png",bbox_inches='tight') | |
corona cases forecasting/main.py
Outdated
| plt.title('New recovered Cases Forecast') | ||
| plt.xticks(rotation=90) | ||
| # plt.figure(figsize=(22,22)) | ||
| plt.savefig("plot3.png",bbox_inches='tight') |
There was a problem hiding this comment.
Suggested change
| plt.savefig("plot3.png",bbox_inches='tight') | |
| plt.savefig("./corona cases forecasting/Results/plot3.png",bbox_inches='tight') | |
corona cases forecasting/main.py
Outdated
| plt.show() | ||
|
|
||
|
|
||
| choice=input("F for fresh cases,D for death cases,R for recovered cases prediction") |
There was a problem hiding this comment.
Suggested change
| choice=input("F for fresh cases,D for death cases,R for recovered cases prediction") | |
| choice=input("F for fresh cases,D for death cases,R for recovered cases prediction: ") | |
corona cases forecasting/main.py
Outdated
| recovered_cases_daily() | ||
| else: | ||
| print("Enter a valid choice") | ||
|
|
There was a problem hiding this comment.
Remove these long trailing blank lines
kaustubhgupta
added
minor-change-not-bug
kaustubhgupta
added
next review needed
santushtisharma10
approved these changes
Apr 11, 2021
kaustubhgupta
requested review from
antrikshmisri
and removed request for
antrikshmisri
antrikshmisri
approved these changes
Apr 13, 2021
santushtisharma10
added
Approved
santushtisharma10
added
gssoc23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a folder 'corona cases forecasting' having python script , result images and requirements.txt.
Fixes #828
Have you read the Contributing Guidelines on Pull Requests?
Type of change
Please delete options that are not relevant.
Checklist:
README.mdTemplate for README.md