Skip to content

Added Photo_to_Ascii #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2021
Merged

Added Photo_to_Ascii #855

merged 7 commits into from
Apr 10, 2021

Conversation

Avishake007
Copy link
Contributor

Description

Here I have added photo to ascii feature which will convert your photo to ascii

Fixes #847

Have you read the Contributing Guidelines on Pull Requests?

  • Yes
  • No

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

Previously

photo_to_ascii

After

photo_to_ascii(2)

kaustubhgupta
kaustubhgupta suggested changes Apr 9, 2021
View reviewed changes
@kaustubhgupta kaustubhgupta added the minor-change-not-bug Suggested a minor change in code, not a bug label Apr 9, 2021
@Avishake007
Copy link
Contributor Author

@kaustubhgupta It's done . Kindly check it

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Apr 10, 2021
Kushal997-das
Kushal997-das approved these changes Apr 10, 2021
View reviewed changes
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

santushtisharma10
santushtisharma10 approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@santushtisharma10 santushtisharma10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work and removed next review needed Approved by some mentors, more approvals needed labels Apr 10, 2021
avinashkranjan
avinashkranjan approved these changes Apr 10, 2021
View reviewed changes
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..💯

@avinashkranjan avinashkranjan merged commit 91e787a into avinashkranjan:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+4 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

@Kushal997-das Kushal997-das Kushal997-das approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level1 Wiki or Major Documentation Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Photo_to_Ascii
6 participants
@Avishake007 @kaustubhgupta @antrikshmisri @avinashkranjan @santushtisharma10 @Kushal997-das