Skip to content

Image viewing GUI #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2021
Merged

Image viewing GUI #888

merged 4 commits into from
Apr 15, 2021

Conversation

Amit366
Copy link
Contributor

@Amit366 Amit366 commented Apr 12, 2021

Description

Added script for Image viewing GUI

Fixes #719

Replace issue_no with the issue number which is fixed in this PR

Have you read the Contributing Guidelines on Pull Requests?

yes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation Update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings
  • I have added tests/screenshots(if any) that prove my fix is effective or that my feature works.

@Amit366
Copy link
Contributor Author

Amit366 commented Apr 12, 2021

@kaustubhgupta please review.

@Amit366
Copy link
Contributor Author

Amit366 commented Apr 12, 2021

@santushtisharma10 please review

kaustubhgupta
kaustubhgupta suggested changes Apr 13, 2021
View reviewed changes
Image_Viewing_GUI/script.py Outdated
global itemslist
n=(n+1)%len(itemslist)
img1 = itemslist[n]
print(img1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this print statement

Image_Viewing_GUI/script.py Outdated
global itemslist
n=(n-1)%len(itemslist)
img1 = itemslist[n]
print(img1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this print statement

@kaustubhgupta kaustubhgupta added the minor-change-not-bug Suggested a minor change in code, not a bug label Apr 13, 2021
@Amit366
Copy link
Contributor Author

Amit366 commented Apr 13, 2021

@kaustubhgupta done

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed minor-change-not-bug Suggested a minor change in code, not a bug labels Apr 14, 2021
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features and removed next review needed Approved by some mentors, more approvals needed labels Apr 15, 2021
avinashkranjan
avinashkranjan approved these changes Apr 15, 2021
View reviewed changes
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinashkranjan avinashkranjan merged commit 47bd8e7 into avinashkranjan:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avinashkranjan avinashkranjan avinashkranjan approved these changes

+3 more reviewers

@kaustubhgupta kaustubhgupta kaustubhgupta approved these changes

@antrikshmisri antrikshmisri antrikshmisri approved these changes

@santushtisharma10 santushtisharma10 santushtisharma10 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level2 Bug fixing, Adding small features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image Viewing GUI
5 participants
@Amit366 @kaustubhgupta @antrikshmisri @avinashkranjan @santushtisharma10