Skip to content

Conversation

ayush-raj8
Copy link
Contributor

@ayush-raj8 ayush-raj8 commented Apr 18, 2021

Description

Python script and model to detect malaria infected cells.

Fixes #893

Replace 893 with the issue number which is fixed in this PR 927

Have you read the Contributing Guidelines on Pull Requests?

  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md
  • My changes generate no new warnings

@@ -0,0 +1,7 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not needed , you can delete it

Malaria/main.py Outdated
os.environ['TF_XLA_FLAGS'] = '--tf_xla_enable_xla_devices'

# reading image
img = Image.open("Images/cell1.jpg")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take input for image path from user

@@ -0,0 +1,450 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert this notebook into .py script and delete this notebook

@kaustubhgupta kaustubhgupta added the bug Something isn't working label Apr 19, 2021
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the malaraidetection.ipynb file along with this change:

@@ -0,0 +1,86 @@
# importing the libraries for loading data and visualisation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name this file as model_training.py instead of script.py

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the third time: DELETE THIS FILE! malariadetection.ipynb

@ayush-raj8
Copy link
Contributor Author

@kaustubhgupta This new deep source python is showing errors because of comments and line too long. This code runs perfectly fine on any python ide e.g. Pycharm.
Line too long cannot be removed as it involves model formation.
image
image

Lines will have more than 88 characters , because this is the standard way of training , testing and forming CNN.

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed and removed bug Something isn't working labels Apr 22, 2021
Copy link

@Kushal997-das Kushal997-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antrikshmisri
Copy link
Contributor

antrikshmisri commented Apr 23, 2021

@kaustubhgupta This new deep source python is showing errors because of comments and line too long. This code runs perfectly fine on any python ide e.g. Pycharm.
Line too long cannot be removed as it involves model formation.
image
image

Lines will have more than 88 characters , because this is the standard way of training , testing and forming CNN.

@ayush-raj8 Have a look at pep8 guidelines for long lines here. Also there are great online pep8 formatters.

@kaustubhgupta kaustubhgupta requested review from antrikshmisri and removed request for antrikshmisri April 26, 2021 05:17
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels Apr 26, 2021
Copy link
Owner

@avinashkranjan avinashkranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avinashkranjan avinashkranjan merged commit b1f219d into avinashkranjan:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of Malaria detection from cell image
6 participants