Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isCollaborator check #142

Merged
merged 4 commits into from
Oct 6, 2023
Merged

feat: add isCollaborator check #142

merged 4 commits into from
Oct 6, 2023

Conversation

avitorio
Copy link
Owner

@avitorio avitorio commented Oct 5, 2023

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2023

🦋 Changeset detected

Latest commit: 13df679

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outstatic-canary ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 9:11am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
outstatic-dev-blog ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 9:11am
outstatic-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2023 9:11am

Copy link
Collaborator

@ZiyadBoshima ZiyadBoshima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @avitorio, I tested your code and it worked fine. Nice work combining the functions under Promise.all. Also, I just removed console.log({ repoExists }) from the file. I am approving this PR.

@avitorio avitorio merged commit 1b9e043 into canary Oct 6, 2023
4 checks passed
@avitorio avitorio deleted the feat/collab-check branch October 6, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants