fix: status-field dynamic filter missing some options #2191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where dynamic filters would not have options because they are not declared anywhere for the neutral state.
Now, that we declare them in the
neutral_when
option, the dynamic filters will know about them and display them.Checklist:
Screenshots
Manual review steps
avo-advanced
xoxo
status
xoxo
value is missingneutral_when
value tofield :status, as: :status, neutral_when: [:xoxo]
xoxo
value is present.Manual reviewer: please leave a comment with output from the test if that's the case.