Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: status-field dynamic filter missing some options #2191

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes an issue where dynamic filters would not have options because they are not declared anywhere for the neutral state.
Now, that we declare them in the neutral_when option, the dynamic filters will know about them and display them.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

Manual review steps

  1. Using avo-advanced
  2. Change one project status field to something different xoxo
  3. Go to the projects Index page and try to set a dynamic filter on status
  4. Observe that the xoxo value is missing
  5. now set the neutral_when value to field :status, as: :status, neutral_when: [:xoxo]
  6. se the dynamic filter again and observe that the xoxo value is present.

Manual reviewer: please leave a comment with output from the test if that's the case.

@github-actions github-actions bot added the Fix label Dec 18, 2023
Copy link

codeclimate bot commented Dec 18, 2023

Code Climate has analyzed commit 54a32b6 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev merged commit 3c4af00 into main Dec 18, 2023
17 of 18 checks passed
@adrianthedev adrianthedev deleted the fix/status-field-dynamic-filter branch December 18, 2023 19:28
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant