[WIP & Experimental] fix: prevent memory bloat in associations when searchable is set to false #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earchable is set to false
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Code Climate has analyzed commit a321956 and detected 0 issues on this pull request. View more on Code Climate. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Commented tests need refactor to test scenarios with |
Paul-Bob
commented
Apr 1, 2024
Comment on lines
45
to
+49
| def new | ||
| @resource.hydrate(record: @record) | ||
| end | ||
|
|
||
| def options |
There was a problem hiding this comment.
To increase performance we can serialize and encrypt the query and pass from new to options through params avoiding the query compute on each options request.
|
Closing to keep the PR list clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is just a POC of
hotwire_comboboximplementation to replace the attach modal select.Can be intersting to implement
hotwire_comboboxon belongs to field and replace every select / searchable interface withhotwire_combobox.As a con
hotwire_comboboxhave dependency on rails 7 which breaks avo support for rails lower than 7.Fixes #2406
Screen.Recording.2024-03-29.at.17.04.32.mov
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.