Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Hidden field #71

Merged
merged 5 commits into from
Jul 7, 2020
Merged

feature: Hidden field #71

merged 5 commits into from
Jul 7, 2020

Conversation

mihaimdm22
Copy link
Contributor

Let me know what you think about this. Thought its needed only on edit.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks, and one more test to make sure that the input works.

lib/avocado/app/fields/hidden_field.rb Outdated Show resolved Hide resolved
spec/system/avocado/avocado_hidden_field_spec.rb Outdated Show resolved Hide resolved
mihaimdm22 and others added 2 commits July 7, 2020 12:43
Co-authored-by: Adrian Marin <adrian@adrianthedev.com>
Co-authored-by: Adrian Marin <adrian@adrianthedev.com>
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #71 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   95.96%   96.02%   +0.05%     
==========================================
  Files          85       87       +2     
  Lines        1861     1886      +25     
==========================================
+ Hits         1786     1811      +25     
  Misses         75       75              
Impacted Files Coverage Δ
lib/avocado/app/fields/hidden_field.rb 100.00% <100.00%> (ø)
lib/avocado/app/resource_fields.rb 100.00% <100.00%> (ø)
spec/dummy/app/services/avocado/resources/user.rb 100.00% <100.00%> (ø)
spec/system/avocado/avocado_hidden_field_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0915109...2e1f542. Read the comment docs.

@mihaimdm22 mihaimdm22 merged commit ad96aae into master Jul 7, 2020
@mihaimdm22 mihaimdm22 deleted the feature--Hidden-field branch July 7, 2020 11:55
@adrianthedev adrianthedev mentioned this pull request Feb 24, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants