Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: fields Help Text #77

Merged
merged 5 commits into from
Jul 15, 2020
Merged

feature: fields Help Text #77

merged 5 commits into from
Jul 15, 2020

Conversation

mihaimdm22
Copy link
Contributor

@mihaimdm22 mihaimdm22 commented Jul 9, 2020

Please let me know what you think about this.

Screenshot 2020-07-10 at 10 17 12

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #77 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   96.06%   96.09%   +0.02%     
==========================================
  Files          91       92       +1     
  Lines        2110     2123      +13     
==========================================
+ Hits         2027     2040      +13     
  Misses         83       83              
Impacted Files Coverage Δ
lib/avocado/app/fields/field.rb 98.38% <100.00%> (+0.02%) ⬆️
spec/dummy/app/services/avocado/resources/user.rb 100.00% <100.00%> (ø)
spec/system/avocado/help_text_spec.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a86bba8...d1e938d. Read the comment docs.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick. Good job!

lib/avocado/app/fields/field.rb Outdated Show resolved Hide resolved
@adrianthedev
Copy link
Collaborator

Also pondering to make the fields wider... Not sure

image

@mihaimdm22 mihaimdm22 merged commit 1e92ccd into master Jul 15, 2020
@mihaimdm22 mihaimdm22 deleted the feature/fields-help branch July 15, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants