Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove autoloading #93

Merged
merged 5 commits into from
Aug 5, 2020
Merged

Conversation

adrianthedev
Copy link
Collaborator

No description provided.

@adrianthedev adrianthedev changed the title Refactor/remove autoloading refactor: remove autoloading Aug 5, 2020
avocado.gemspec Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
"public gem pushes."
end

spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

avocado.gemspec Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
"public gem pushes."
end

spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

avocado.gemspec Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
"public gem pushes."
end

spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

avocado.gemspec Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
"public gem pushes."
end

spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

avocado.gemspec Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
"public gem pushes."
end

spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

lib/avocado.rb Outdated
@@ -22,3 +16,5 @@ def root_path
end
end
end

require_relative "avocado/engine" if defined?(Rails)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #93 into master will decrease coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   96.42%   96.37%   -0.05%     
==========================================
  Files         100      100              
  Lines        2348     2346       -2     
==========================================
- Hits         2264     2261       -3     
- Misses         84       85       +1     
Impacted Files Coverage Δ
lib/avocado/engine.rb 78.26% <75.00%> (-2.70%) ⬇️
lib/avocado.rb 88.88% <100.00%> (-3.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51487f5...b3bfedc. Read the comment docs.

@adrianthedev adrianthedev merged commit 7db63c7 into master Aug 5, 2020
@adrianthedev adrianthedev deleted the refactor/remove-autoloading branch August 5, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant