-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove autoloading #93
Conversation
avocado.gemspec
Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
"public gem pushes." | |||
end | |||
|
|||
spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] | |||
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
avocado.gemspec
Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
"public gem pushes." | |||
end | |||
|
|||
spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] | |||
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
avocado.gemspec
Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
"public gem pushes." | |||
end | |||
|
|||
spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] | |||
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
avocado.gemspec
Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
"public gem pushes." | |||
end | |||
|
|||
spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] | |||
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
avocado.gemspec
Outdated
@@ -23,7 +23,7 @@ Gem::Specification.new do |spec| | |||
"public gem pushes." | |||
end | |||
|
|||
spec.files = Dir["{app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md"] | |||
spec.files = Dir["{bin,app,config,db,lib,public}/**/*", "MIT-LICENSE", "Rakefile", "README.md", "avocado.gemspec", 'Gemfile', 'Gemfile.lock'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
lib/avocado.rb
Outdated
@@ -22,3 +16,5 @@ def root_path | |||
end | |||
end | |||
end | |||
|
|||
require_relative "avocado/engine" if defined?(Rails) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
- Coverage 96.42% 96.37% -0.05%
==========================================
Files 100 100
Lines 2348 2346 -2
==========================================
- Hits 2264 2261 -3
- Misses 84 85 +1
Continue to review full report at Codecov.
|
No description provided.