Skip to content

Fixing how 'precision' adjusts the exponent if there's digits #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

Fixing how 'precision' adjusts the exponent if there's digits #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions dist/filesize.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,11 @@ function filesize (arg, {
// Zero is now a special case because bytes divide by 1
if (num === 0) {
result[0] = 0;

if (precision > 0) {
result[0] = result[0].toPrecision(precision);
}

u = result[1] = STRINGS.symbol[standard][bits ? BITS : BYTES][e];
} else {
val = num / (base === 2 ? Math.pow(2, e * 10) : Math.pow(1000, e));
Expand All @@ -188,6 +193,17 @@ function filesize (arg, {
e++;
}

// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
const [ newResult, newExponent ] = result[0].split(E);
result[0] = newResult;

if (newExponent !== undefined) {
e += parseInt(newExponent, 10);
}
}

u = result[1] = base === 10 && e === 1 ? bits ? SI_KBIT : SI_KBYTE : STRINGS.symbol[standard][bits ? BITS : BYTES][e];
}

Expand All @@ -196,12 +212,6 @@ function filesize (arg, {
result[0] = -result[0];
}

// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
result[0] = result[0].split(E)[0];
}

// Applying custom symbol
result[1] = symbols[result[1]] || result[1];

Expand Down
22 changes: 16 additions & 6 deletions dist/filesize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,11 @@ function filesize (arg, {
// Zero is now a special case because bytes divide by 1
if (num === 0) {
result[0] = 0;

if (precision > 0) {
result[0] = result[0].toPrecision(precision);
}

u = result[1] = STRINGS.symbol[standard][bits ? BITS : BYTES][e];
} else {
val = num / (base === 2 ? Math.pow(2, e * 10) : Math.pow(1000, e));
Expand All @@ -184,6 +189,17 @@ function filesize (arg, {
e++;
}

// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
const [ newResult, newExponent ] = result[0].split(E);
result[0] = newResult;

if (newExponent !== undefined) {
e += parseInt(newExponent, 10);
}
}

u = result[1] = base === 10 && e === 1 ? bits ? SI_KBIT : SI_KBYTE : STRINGS.symbol[standard][bits ? BITS : BYTES][e];
}

Expand All @@ -192,12 +208,6 @@ function filesize (arg, {
result[0] = -result[0];
}

// Setting optional precision
if (precision > 0) {
result[0] = result[0].toPrecision(precision);
result[0] = result[0].split(E)[0];
}

// Applying custom symbol
result[1] = symbols[result[1]] || result[1];

Expand Down
2 changes: 1 addition & 1 deletion dist/filesize.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading