Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions problems/reverse-string/reverse_string.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
package reverse_string

func reverseString(s string) string {
runes := []rune(s)
for i, j := 0, len(runes)-1; i < j; i, j = i+1, j-1 {
runes[i], runes[j] = runes[j], runes[i]
func reverseString(s []byte) {
for i, j := 0, len(s)-1; i < j; i, j = i+1, j-1 {
s[i], s[j] = s[j], s[i]
}
return string(runes)
}
34 changes: 24 additions & 10 deletions problems/reverse-string/reverse_string_test.go
Original file line number Diff line number Diff line change
@@ -1,18 +1,32 @@
package reverse_string

import "testing"
import (
"reflect"
"testing"
)

type caseType struct {
input []byte
expected []byte
}

func TestReverseString(t *testing.T) {
tests := map[string]string{
"hello, world": "dlrow ,olleh",
"你好,世界": "界世,好你",
"A man, a plan, a canal: Panama": "amanaP :lanac a ,nalp a ,nam A",
tests := [...]caseType{
{
input: []byte{'h', 'e', 'l', 'l', 'o'},
expected: []byte{'o', 'l', 'l', 'e', 'h'},
},
{
input: []byte{'H', 'a', 'n', 'n', 'a', 'h'},
expected: []byte{'h', 'a', 'n', 'n', 'a', 'H'},
},
}

for input, expected := range tests {
output := reverseString(input)
if output != expected {
t.Fatalf("input: %v, output: %v, expected: %v", input, output, expected)
for _, tc := range tests {
output := make([]byte, len(tc.input))
copy(output, tc.input)
reverseString(output)
if !reflect.DeepEqual(output, tc.expected) {
t.Fatalf("input: %v, output: %v, expected: %v", tc.input, output, tc.expected)
}
}
}