use explicit tokenValidityUnits 'days' for userPoolClient refreshToken #10706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joekiller
force-pushed
the
category-auth/use-explicit-token-validity-units
branch
2 times, most recently
from
0cd9f1f to
468760c
Compare
Fixes RefreshToken sometimes not using correct units if it had been manually modified in the past ie aws-cloudformation/cloudformation-coverage-roadmap#606 (comment)
joekiller
force-pushed
the
category-auth/use-explicit-token-validity-units
branch
from
468760c to
29c621f
Compare
siegerts
added
the
first-time-contributor
|
Seems unclear to me why the run-pr-e2e failed. Is there something I need to update? |
edwardfoyle
approved these changes
Jul 21, 2022
danielleadams
approved these changes
Jul 22, 2022
sundersc
pushed a commit
to sundersc/amplify-cli
that referenced
this pull request
Jul 26, 2022
aws-amplify#10706) Fixes RefreshToken sometimes not using correct units if it had been manually modified in the past ie aws-cloudformation/cloudformation-coverage-roadmap#606 (comment)
joekiller
deleted the
category-auth/use-explicit-token-validity-units
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RefreshToken sometimes not using correct units if it had been manually modified in the past ie aws-cloudformation/cloudformation-coverage-roadmap#606 (comment)
Description of changes
use explicit tokenValidityUnits 'days' for userPoolClient refreshToken otherwise units may not match what the CLI implies.
Issue #, if available
N/A
Description of how you validated changes
Added tests and validated CFN.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.