chore(aws_common,3.0): Make AWSResult sealed #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
feat/repo/more-dart-3
branch
2 times, most recently
from
1f2a341 to
eae1e2d
Compare
dnys1
force-pushed
the
chore/core/sealed-types
branch
from
90f0444 to
80f8dc1
Compare
dnys1
force-pushed
the
feat/repo/more-dart-3
branch
from
eae1e2d to
ca370d9
Compare
dnys1
force-pushed
the
chore/core/sealed-types
branch
from
80f8dc1 to
370a050
Compare
dnys1
force-pushed
the
feat/repo/more-dart-3
branch
from
ca370d9 to
51f2d2d
Compare
NikaHsn
reviewed
May 8, 2023
Comment on lines
+38
to
+41
| V get value; | ||
|
|
||
| /// The value of the result, or null if there was an error retrieving it. | ||
| T? get valueOrNull { | ||
| switch (type) { | ||
| case AWSResultType.success: | ||
| // value will be non-null since it is required in AWSResult.success. | ||
| return _value!; | ||
| case AWSResultType.error: | ||
| return null; | ||
| V? get valueOrNull; |
There was a problem hiding this comment.
given V extends Object? I'm not sure if we need this
There was a problem hiding this comment.
The value getter throws for error results whereas this returns null
NikaHsn
previously approved these changes
May 9, 2023
dnys1
force-pushed
the
chore/core/sealed-types
branch
from
370a050 to
260a7ac
Compare
dnys1
force-pushed
the
feat/repo/more-dart-3
branch
from
51f2d2d to
2103375
Compare
Jordan-Nelson
approved these changes
May 9, 2023
NikaHsn
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pattern matching/functional capabilities to
AWSResult.