Next major version/merge in app #10430

cshfang · 2022-10-05T21:49:46Z

Description of changes

This PR merges in the in-app-messaging/main branch and updates dependency versions for notifications.

Merge conflicts were resolved by taking --ours with the exception of Analytics.test.ts and config.yaml.

This PR does also include a version bump to synchronize dependencies for the notifications package with peer packages in this commit.

Description of how you validated changes

Manually tested that upgrading pinpoint client is scoped to notifications - does not affect Analytics.

yarn test passes.

Checklist

PR description included
yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

In app poc migration

…mitted in Analytic category

…vents Conditionally emit analytic events

removed some unused types

refactor: Updated pinpoint provider * Removed race condition on initialization * Added private API for updating endpoint * Updated to use pinpoint client more directly without need to add client abstraction layer * Added shared endpoint util * Refactored and renamed cached endpoint util * Add types to cachedUuid functions * Add types to cachedUuid function parameters Co-authored-by: Chris Fang <chrfang@amazon.com>

feature: add clearStoredInAppMessages method

* feat: Add initial set of in-app message filters * Move filter logic to provider * Update in-app messaging handler naming * Make matchesAttributes() private * Update comment in typing Co-authored-by: Chris Fang <chrfang@amazon.com>

* feat: Added handling for Quiet Time * Added condition - start and end times must not be the same Co-authored-by: Chris Fang <chrfang@amazon.com>

feat: Add session tracking

Remove asyncstorage

)

* feat: modal ui for in-app messaging * feat: adds landscape support for modal * support ios orientations * review changes: constants, util function for layout decision * review fixes: styling and positioning * added constant for modal border radius * remove array style * merge conflict resolved and tests fixed * remove style array * Updated snapshots for tests * adjust text and button left alignment * align the image to the center of the modal * updated snapshots * fix: center image and contain x icon box * Updated snapshot * fix: image centering * fix: self closing view * fix: remove empty view and use margin and fix layout without image * fix: remove color overrides used for dev * snapshots updated * fix: review changes renaming variables and comments * refactor: use InAppMessagingLayout type for layout prop in util function * refactor: comment on the function params Co-authored-by: Caleb Pollman <cpollman1@gmail.com> * fix: spacing for the comments * refactor: type name in function comments Co-authored-by: Caleb Pollman <cpollman1@gmail.com>

…dle landscape mode (aws-amplify#9897)

aws-amplify#10002) * fix(in-app-messaging): Disable web session tracker when in non-browser environment * Update unit tests to better mock out dependencies Co-authored-by: Chris Fang <chrfang@amazon.com>

Co-authored-by: Chris Fang <chrfang@amazon.com>

* Added ExpoSQLiteAdapter and Code Sharing for common files * changes to naming and updates regarding feedback from Draft PR * remove local changes from .vscode and package.json * Apply feedback from Caleb's and Chris's Code Review * remove unused imports and warn about db errors * added @types/react-native-sqlite-storage as devDependency for improved typing * Apply feedback from Chris and fix the initial sync problem * re-order dependencies * Addressed feedback from Chris * Assign any type to Result from SQLResultSetRowList as defined in expo-sqlite docs * Seperate entrypoint for ExpoSQLiteAdapter * Apply feedback from Caleb & Chris, Remove unused variable and separate entrypoints * Remove unnecesary async, alphabetic order for import statements and npm packages, single transaction for batchSave * remove unnecessary casting * Removed version, size and description args from openDatabase as they are not being used * Removed version, size and description args from openDatabase and moved entrypoint files in folders * Add initial unit tests for ExpoSQLiteAdapter * Add more tests and change the location * Address feedback from Chris * ci: canaries rn workaround (aws-amplify#10020) * fix: decrease error handler verbosity on self recovering errors (aws-amplify#10030) restore warning message * fix: Update Auth to import JS using named export (aws-amplify#10033) Imports specific functions instead of the whole JS module to improve bundle size * fix(analytics): Buffer limit should be adhered to (aws-amplify#10015) Co-authored-by: Chris Fang <chrfang@amazon.com> * chore(CODEOWNERS): update geo category codeowners (aws-amplify#10048) * fix: pin vue version (aws-amplify#10052) * fix(amazon-cognito-identity-js): Missing cognito user challenge name … (aws-amplify#10047) * fix(amazon-cognito-identity-js): Missing cognito user challenge name type * fix(type): Fix other functions reported in aws-amplify#6974 * Update Auth units with correct ChallengeName Co-authored-by: elorzafe <elorzafe@amazon.com> * chore: preparing release * chore(release): Publish [ci skip] - amazon-cognito-identity-js@5.2.10 - @aws-amplify/ui-angular@1.0.54 - @aws-amplify/ui-components@1.9.25 - @aws-amplify/ui-react@1.2.45 - @aws-amplify/ui-storybook@2.0.45 - @aws-amplify/ui-vue@1.1.39 - @aws-amplify/analytics@5.2.12 - @aws-amplify/api-graphql@2.3.9 - @aws-amplify/api-rest@2.0.45 - @aws-amplify/api@4.0.45 - @aws-amplify/auth@4.5.9 - aws-amplify-angular@6.0.45 - aws-amplify-react@5.1.28 - aws-amplify-vue@2.1.7 - aws-amplify@4.3.27 - @aws-amplify/cache@4.0.47 - @aws-amplify/core@4.5.9 - @aws-amplify/datastore-storage-adapter@1.3.5 - @aws-amplify/datastore@3.12.2 - @aws-amplify/geo@1.3.8 - @aws-amplify/interactions@4.0.45 - @aws-amplify/predictions@4.0.45 - @aws-amplify/pubsub@4.4.6 - @aws-amplify/pushnotification@4.3.24 - @aws-amplify/storage@4.4.28 - @aws-amplify/xr@3.0.45 * chore(release): update version.ts [ci skip] * chore: add dpilch to datastore codeowners (aws-amplify#10031) * chore(datastore): Add schema-drift integration test (aws-amplify#10077) * Datastore/feat user agent suffix (aws-amplify#10086) * Adds suffix to user agent for calls to API initiated by DataStore * Attempts to fix first half of user agent not being sent * Makes setting of user agent header more concise * Moves appending of suffix to user agent to core library * Moves user agent suffix constant to common util in datastore * Removes unused import * Unit test for api-graphql * Pulls in user agent suffix from datastore utils class * Adds unit test for getAmplifyUserAgent with and without content * Fixes issue found while testing, line too long. * Adds test for DataStore mutation.ts * Tests user agent suffix in datastore sync * Adds user agent suffix assertion to subscription test * Fixes variable declaration: const instead of let * Removes leftover lines of code from testing objectContains * Removes code style changes unrelated to user agent suffix * Removes code style changes unrelated to user agent suffix * Removes unnecessary null value option for userAgentSuffix - undefined is sufficient * Replaces imports from lib-esm * Replaces hard-coded string in assertion with constant from util file * Moves var declaration under import * Makes test method names more descriptive Co-authored-by: Erin Beal <erinleig@amazon.com> * chore(data): update CODEOWNERS file * Update .github/CODEOWNERS Co-authored-by: Jon Wire <iambipedal@gmail.com> * fix: preserve ssr context when using DataStore (aws-amplify#10088) * fix: Update AmazonPersonalizeProvider Analytics typings (aws-amplify#10076) * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.55 - @aws-amplify/ui-components@1.9.26 - @aws-amplify/ui-react@1.2.46 - @aws-amplify/ui-storybook@2.0.46 - @aws-amplify/ui-vue@1.1.40 - @aws-amplify/analytics@5.2.13 - @aws-amplify/api-graphql@2.3.10 - @aws-amplify/api-rest@2.0.46 - @aws-amplify/api@4.0.46 - @aws-amplify/auth@4.5.10 - aws-amplify-angular@6.0.46 - aws-amplify-react@5.1.29 - aws-amplify@4.3.28 - @aws-amplify/cache@4.0.48 - @aws-amplify/core@4.5.10 - @aws-amplify/datastore-storage-adapter@1.3.6 - @aws-amplify/datastore@3.12.3 - @aws-amplify/geo@1.3.9 - @aws-amplify/interactions@4.0.46 - @aws-amplify/predictions@4.0.46 - @aws-amplify/pubsub@4.4.7 - @aws-amplify/pushnotification@4.3.25 - @aws-amplify/storage@4.4.29 - @aws-amplify/xr@3.0.46 * chore(release): update version.ts [ci skip] * Fix typo in contributing guide (aws-amplify#10104) * feat(@aws-amplify/storage): Access all files from S3 with List API (aws-amplify#10095) Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> * feat(@aws-amplify/auth): Auto sign in after sign up (aws-amplify#10126) Fixes: aws-amplify#6320 aws-amplify#3882 aws-amplify#3631 aws-amplify#6018 Co-authored-by: Balashova <helgabalashova> Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.56 - @aws-amplify/ui-components@1.9.27 - @aws-amplify/ui-react@1.2.47 - @aws-amplify/ui-storybook@2.0.47 - @aws-amplify/ui-vue@1.1.41 - @aws-amplify/analytics@5.2.14 - @aws-amplify/api-graphql@2.3.11 - @aws-amplify/api-rest@2.0.47 - @aws-amplify/api@4.0.47 - @aws-amplify/auth@4.6.0 - aws-amplify-angular@6.0.47 - aws-amplify-react@5.1.30 - aws-amplify@4.3.29 - @aws-amplify/cache@4.0.49 - @aws-amplify/core@4.6.0 - @aws-amplify/datastore-storage-adapter@1.3.7 - @aws-amplify/datastore@3.12.4 - @aws-amplify/geo@1.3.10 - @aws-amplify/interactions@4.0.47 - @aws-amplify/predictions@4.0.47 - @aws-amplify/pubsub@4.4.8 - @aws-amplify/pushnotification@4.3.26 - @aws-amplify/storage@4.5.0 - @aws-amplify/xr@3.0.47 * chore(release): update version.ts [ci skip] * Fix grammar errors and clarify testing requirements (aws-amplify#10122) Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> * fix(auth): Unauthenticated identity throws AuthError without user … (aws-amplify#10090) Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> * aws-amplifyGH-9824 - PubSub Connection state tracking for AppSyncRealtime (aws-amplify#10063) Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> * chore(deps): bump tzinfo from 1.2.9 to 1.2.10 in /docs (aws-amplify#10102) * fix(@aws-amplify/auth): fix storage bug for auto sign in value (aws-amplify#10139) Co-authored-by: Balashova <olybalas@98dd60782ea0.ant.amazon.com> Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.57 - @aws-amplify/ui-components@1.9.28 - @aws-amplify/ui-react@1.2.48 - @aws-amplify/ui-storybook@2.0.48 - @aws-amplify/ui-vue@1.1.42 - @aws-amplify/analytics@5.2.15 - @aws-amplify/api-graphql@2.3.12 - @aws-amplify/api-rest@2.0.48 - @aws-amplify/api@4.0.48 - @aws-amplify/auth@4.6.1 - aws-amplify-angular@6.0.48 - aws-amplify-react@5.1.31 - aws-amplify@4.3.30 - @aws-amplify/cache@4.0.50 - @aws-amplify/core@4.6.1 - @aws-amplify/datastore-storage-adapter@1.3.8 - @aws-amplify/datastore@3.12.5 - @aws-amplify/geo@1.3.11 - @aws-amplify/interactions@4.0.48 - @aws-amplify/predictions@4.0.48 - @aws-amplify/pubsub@4.4.9 - @aws-amplify/pushnotification@4.3.27 - @aws-amplify/storage@4.5.1 - @aws-amplify/xr@3.0.48 * chore(release): update version.ts [ci skip] * Revert "Merge branch 'expo-sqlite-adapter-unit-tests' into main" (aws-amplify#10151) This reverts commit d8637cc, reversing changes made to 186349e. * feat(@aws-amplify/core): Throw Error if body attribute passed to Sign… (aws-amplify#10137) * feat(@aws-amplify/core): Throw Error if body attribute passed to Signer.sign() Co-authored-by: Ahilash Sasidharan ahilashs@yahoo.com * Set space-before-function-paren to false for unit test * Make changes in response to PR comments * Make changes in response to PR comments * Find issue with unit tests * Move sign error tests into Signer-test * Set space-before-function-paren to false for unit test * Run test with space-before-function-paren set to true * Fix space before function error * Update tslint.json Set "space-before-function-paren" back to default setting. * Remove spaces before keyword "function" Return original formatting rule of no-spaces before "function" keyword. Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> * fix(datastore): make di context fields private (aws-amplify#10162) * Updating config.yml to mitigate circle CI pipeline failures from outdated Xcode image (aws-amplify#10158) * updating config.yml for testing changes to staging * removing android integ tests for now * Update config.yml * removing code used for testing Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> * kinesis fix * update personalize type to accomodate string * Revert "update personalize type to accomodate string" This reverts commit 9326beb. * Revert "kinesis fix" This reverts commit 763609b. * fix(pubsub): Add distinct RN Reachibility implementation (aws-amplify#10175) * fix(pubsub): Add distinct RN Reachibility implementation * fix(PubSub): Fix monitor tests * Fix: Analytics Type issue (aws-amplify#10185) * kinesis fix * ci: automate GitHub releases with lerna (aws-amplify#10189) Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com> Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> * chore: ci: Disabling integ_rn_ios_datastore_sqlite_adapter test (aws-amplify#10193) * Disabling integ_rn_ios_datastore_sqlite_adapter test * Update config.yml * Revert "ci: automate GitHub releases with lerna (aws-amplify#10189)" This reverts commit f59fa9f. * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.58 - @aws-amplify/ui-components@1.9.29 - @aws-amplify/ui-react@1.2.49 - @aws-amplify/ui-storybook@2.0.49 - @aws-amplify/ui-vue@1.1.43 - @aws-amplify/analytics@5.2.16 - @aws-amplify/api-graphql@2.3.13 - @aws-amplify/api-rest@2.0.49 - @aws-amplify/api@4.0.49 - @aws-amplify/auth@4.6.2 - aws-amplify-angular@6.0.49 - aws-amplify-react@5.1.32 - aws-amplify@4.3.31 - @aws-amplify/cache@4.0.51 - @aws-amplify/core@4.7.0 - @aws-amplify/datastore-storage-adapter@1.3.9 - @aws-amplify/datastore@3.12.6 - @aws-amplify/geo@1.3.12 - @aws-amplify/interactions@4.0.49 - @aws-amplify/predictions@4.0.49 - @aws-amplify/pubsub@4.4.10 - @aws-amplify/pushnotification@4.3.28 - @aws-amplify/storage@4.5.2 - @aws-amplify/xr@3.0.49 * chore(release): update version.ts [ci skip] * fix:(@aws-amplify/interactions): refactor-lex-v1 (aws-amplify#10155) * fix: An update to @types/lodash breaks the build - specify last working version to unblock (aws-amplify#10221) * fix(interactions): fix configure default provider (aws-amplify#10215) * fix(interactions): fix configure default provider * chore: pin @types/lodash version in aws-amplify-angular Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com> * feat: PubSub Connection state tracking for MQTT and IoT providers (aws-amplify#10136) * feat: PubSub Connection state tracking for MQTT and IoT providers * fix: Add disconnect message on connection lost * fix(pubsub): Connection Ack verification bug (aws-amplify#10200) * fex(pubsub): Add distinct RN Reachibility implementation * fix(PubSub): Monitor tests * fix(pubsub): Connection Ack verification bug * Fix the test * fix: Add tests to cover the fixed bug * Update packages/pubsub/src/Providers/AWSAppSyncRealTimeProvider/index.ts Co-authored-by: Francisco Rodriguez <elorzafe@amazon.com> * Update packages/pubsub/__tests__/AWSAppSyncRealTimeProvider.test.ts Co-authored-by: Francisco Rodriguez <elorzafe@amazon.com> * Test fix * Fix test Co-authored-by: Francisco Rodriguez <elorzafe@amazon.com> * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.59 - @aws-amplify/ui-components@1.9.30 - @aws-amplify/ui-react@1.2.50 - @aws-amplify/ui-storybook@2.0.50 - @aws-amplify/ui-vue@1.1.44 - @aws-amplify/analytics@5.2.17 - @aws-amplify/api-graphql@2.3.14 - @aws-amplify/api-rest@2.0.50 - @aws-amplify/api@4.0.50 - @aws-amplify/auth@4.6.3 - aws-amplify-angular@6.0.50 - aws-amplify-react@5.1.33 - aws-amplify@4.3.32 - @aws-amplify/cache@4.0.52 - @aws-amplify/core@4.7.1 - @aws-amplify/datastore-storage-adapter@1.3.10 - @aws-amplify/datastore@3.12.7 - @aws-amplify/geo@1.3.13 - @aws-amplify/interactions@4.0.50 - @aws-amplify/predictions@4.0.50 - @aws-amplify/pubsub@4.5.0 - @aws-amplify/pushnotification@4.3.29 - @aws-amplify/storage@4.5.3 - @aws-amplify/xr@3.0.50 * chore(release): update version.ts [ci skip] * fix(interactions): fix addPluggable API (aws-amplify#10250) * fix(interactions): fix addPluggable API * fix(interactions): remove Add a invalid pluggable test Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com> * chore: preparing release * chore(release): Publish [ci skip] - @aws-amplify/ui-angular@1.0.60 - @aws-amplify/ui-components@1.9.31 - @aws-amplify/ui-react@1.2.51 - @aws-amplify/ui-storybook@2.0.51 - @aws-amplify/ui-vue@1.1.45 - @aws-amplify/analytics@5.2.18 - @aws-amplify/api-graphql@2.3.15 - @aws-amplify/api-rest@2.0.51 - @aws-amplify/api@4.0.51 - @aws-amplify/auth@4.6.4 - aws-amplify-angular@6.0.51 - aws-amplify-react@5.1.34 - aws-amplify@4.3.33 - @aws-amplify/cache@4.0.53 - @aws-amplify/core@4.7.2 - @aws-amplify/datastore-storage-adapter@1.3.11 - @aws-amplify/datastore@3.12.8 - @aws-amplify/geo@1.3.14 - @aws-amplify/interactions@4.0.51 - @aws-amplify/predictions@4.0.51 - @aws-amplify/pubsub@4.5.1 - @aws-amplify/pushnotification@4.3.30 - @aws-amplify/storage@4.5.4 - @aws-amplify/xr@3.0.51 * chore(release): update version.ts [ci skip] * chore: fixed build, minimatch dep (aws-amplify#10261) * feat(@aws-amplify/interactions): call onComplete callback with entire response (aws-amplify#10248) * feat(interactions): call onComplete callback with entire response * chore(in-app-messaging): version bump Co-authored-by: chintannp <88387035+chintannp@users.noreply.github.com> Co-authored-by: Caleb Pollman <cpollman@amazon.com> Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com> Co-authored-by: Dane Pilcher <dppilche@amazon.com> Co-authored-by: James Au <40404256+jamesaucode@users.noreply.github.com> Co-authored-by: Chris Fang <chrfang@amazon.com> Co-authored-by: Satana Charuwichitratana <satana.charu@gmail.com> Co-authored-by: elorzafe <elorzafe@amazon.com> Co-authored-by: Aaron S <stocaaro@stocad.com> Co-authored-by: aws-amplify-bot <aws@amazon.com> Co-authored-by: Michael Law <1365977+lawmicha@users.noreply.github.com> Co-authored-by: erinleigh90 <106691284+erinleigh90@users.noreply.github.com> Co-authored-by: Erin Beal <erinleig@amazon.com> Co-authored-by: David McAfee <mcafd@amazon.com> Co-authored-by: Jon Wire <iambipedal@gmail.com> Co-authored-by: Amelia Hill <49414147+amehi0index@users.noreply.github.com> Co-authored-by: Venkata Ramyasri Kota <34170013+kvramyasri7@users.noreply.github.com> Co-authored-by: Aaron S <94858815+stocaaro@users.noreply.github.com> Co-authored-by: Olya Balashova <42189299+helgabalashova@users.noreply.github.com> Co-authored-by: Francisco Rodriguez <frodriguez.cs@gmail.com> Co-authored-by: James Au <auchu@amazon.com> Co-authored-by: Kha Truong <64438356+khatruong2009@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Balashova <olybalas@98dd60782ea0.ant.amazon.com> Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com> Co-authored-by: Katie Goines <30757403+katiegoines@users.noreply.github.com> Co-authored-by: Ashika Kasiviswanathan Arumugakarthik <akasivis@amazon.com> Co-authored-by: Ashwin Kumar <ashwinkumar2468@gmail.com> Co-authored-by: Sridhar <ashwsrir@bcd07413f71a.ant.amazon.com> Co-authored-by: Katie Goines <katiegoi@amazon.com>

#### Description of changes  This PR restores the `aws-amplify-react-native` package to its state on the `main` branch. All relevant changes have been migrated to Amplify UI and this package should not be used with in-app messaging. Also pinned the version of the pinpoint client used in `notifications` to a specific targeted version. Latest version of AWS SDK is currently resulting in build failures due to webpack incompatibility. This can addressed at some later time across the JS monorepo. #### Description of how you validated changes `yarn test` #### Checklist  - [x] PR description included - [x] `yarn test` passes By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: Chris Fang <chrfang@amazon.com>

…-app

katiegoines · 2022-10-05T21:56:46Z

.circleci/config.yml

@@ -1219,6 +1219,7 @@ releasable_branches: &releasable_branches
      - ui-components/main
      - 1.0-stable
      - geo/main
+      - in-app-messaging/main


Should this stay in?

Probably don't need this anymore but I left it for now since other merged features (like geo) are still there too. We can purge it all later at the same time if we want/need.

lgtm-com · 2022-10-05T21:59:00Z

This pull request introduces 1 alert when merging 80b9ea0 into 58014c5 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

jimblanc

Change looks good to me, I mostly ignored things in notifications assuming those change have been reviewed separately.

jimblanc · 2022-10-05T21:53:25Z

.circleci/config.yml

@@ -1219,6 +1219,7 @@ releasable_branches: &releasable_branches
      - ui-components/main
      - 1.0-stable
      - geo/main
+      - in-app-messaging/main


Do we need this & the associated script in package.json still?

Probably not but I left it for now since other features are still there too

codecov-commenter · 2022-10-05T22:12:22Z

Codecov Report

Merging #10430 (80b9ea0) into next-major-version/5 (58014c5) will increase coverage by 0.09%.
The diff coverage is 87.40%.

@@                   Coverage Diff                    @@
##           next-major-version/5   #10430      +/-   ##
========================================================
+ Coverage                 84.49%   84.58%   +0.09%     
========================================================
  Files                       260      271      +11     
  Lines                     18776    19401     +625     
  Branches                   4052     4198     +146     
========================================================
+ Hits                      15864    16410     +546     
- Misses                     2822     2901      +79     
  Partials                     90       90

Impacted Files	Coverage Δ
...rc/InAppMessaging/SessionTracker/SessionTracker.ts	`26.31% <26.31%> (ø)`
...ppMessaging/Providers/AWSPinpointProvider/utils.ts	`79.61% <79.61%> (ø)`
...ppMessaging/Providers/AWSPinpointProvider/index.ts	`91.62% <91.62%> (ø)`
packages/analytics/src/Analytics.ts	`64.13% <100.00%> (+1.00%)`	⬆️
packages/aws-amplify/src/index.ts	`100.00% <100.00%> (ø)`
packages/core/src/Amplify.ts	`100.00% <100.00%> (ø)`
...notifications/src/InAppMessaging/InAppMessaging.ts	`100.00% <100.00%> (ø)`
...ppMessaging/Providers/AWSPinpointProvider/types.ts	`100.00% <100.00%> (ø)`
...otifications/src/InAppMessaging/Providers/index.ts	`100.00% <100.00%> (ø)`
...cations/src/InAppMessaging/SessionTracker/index.ts	`100.00% <100.00%> (ø)`
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

calebpollman

LGTM 🚢

lgtm-com · 2022-10-06T19:15:48Z

This pull request introduces 1 alert when merging ddc2882 into 6d98927 - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

calebpollman and others added 30 commits July 21, 2021 13:47

migrating POC

8befa77

Merge branch 'main' into in-app-messages-poc

d922257

clean up some references to analytics in the notifications directory

f1af169

removed InAppMessagesContext, minor clean up

82ae29e

Merge pull request #1 from calebpollman/in-app-poc-migration

2e18742

In app poc migration

add boolean check for determining whether analytic events should be e…

066a9b0

…mitted in Analytic category

Merge pull request #2 from calebpollman/conditionally-emit-analytic-e…

dfaaaf7

…vents Conditionally emit analytic events

removed some unused types

9902c3c

Merge pull request #3 from calebpollman/remove-unused-types

2e472b9

removed some unused types

Merge branch 'main' into in-app-messages

16c8583

feature: add clearStoredInAppMessages method

b4b068d

Merge pull request #6 from calebpollman/add-clear-stored-messages

d98c869

feature: add clearStoredInAppMessages method

Merge branch 'main' into in-app-messages

6b4f4e7

feat: Add initial set of in-app message filters (#7)

812d81a

* feat: Add initial set of in-app message filters * Move filter logic to provider * Update in-app messaging handler naming * Make matchesAttributes() private * Update comment in typing Co-authored-by: Chris Fang <chrfang@amazon.com>

Add quiet time (#8)

8d9f78e

* feat: Added handling for Quiet Time * Added condition - start and end times must not be the same Co-authored-by: Chris Fang <chrfang@amazon.com>

feat: Add session tracking

494cb2b

Merge branch 'main' into in-app-messages

8ee09d1

Add logic for display caps

afa3a39

Update type to be more specific

0566c4c

Address comments

ca05111

Merge pull request #9 from cshfang/add-session-cap

9e8de9f

feat: Add session tracking

refactor: Remove AsyncStorage from category

b2e40b2

Remove AsyncStorage dependency from package.json

e642df4

Don't parse JSON on null getItem result

9b70eb7

Set initialized to true only if init is successful

54c31c4

Merge pull request aws-amplify#10 from cshfang/remove-asyncstorage

f89105a

Remove asyncstorage

add notifications package to aws-amplify dependencies

da1caa5

Merge branch 'main' into in-app-messages

c9a873b

Merge branch 'in-app-messages' into update-aws-amplify-deps

cea7c57

calebpollman and others added 16 commits May 9, 2022 16:21

chore(in-app-messaging): add useDeviceOrientation hook (aws-amplify#9881

12fddc3

)

fix: replace unused constant in the test file (aws-amplify#9894)

7636d31

chore(in-app-messaging): refactor InAppMessaging UI components to han…

6cd8d45

…dle landscape mode (aws-amplify#9897)

Merge branch 'main' into in-app-messaging/staging

932b339

Merge branch 'main' into in-app-messaging/main

d075448

Merge branch 'in-app-messaging/staging' into in-app-messaging/main

f01b6ca

chore(in-app-messaging): version bump (aws-amplify#9928)

3322097

fix(in-app-messaging): Disable web session tracker when in non-browse… (

c5f3b75

aws-amplify#10002) * fix(in-app-messaging): Disable web session tracker when in non-browser environment * Update unit tests to better mock out dependencies Co-authored-by: Chris Fang <chrfang@amazon.com>

Merge branch 'main' into in-app-messaging/main

b6c42cb

Merge branch 'in-app-messaging/staging' into in-app-messaging/main

1ac10ce

chore(in-app-messaging): version bump (aws-amplify#10021)

d042ce9

Co-authored-by: Chris Fang <chrfang@amazon.com>

Merge branch 'in-app-messaging/main' into next-major-version/merge-in…

705324a

…-app

chore(in-app-messaging): version bump

80b9ea0

cshfang requested review from a team as code owners October 5, 2022 21:49

katiegoines reviewed Oct 5, 2022

View reviewed changes

jimblanc approved these changes Oct 5, 2022

View reviewed changes

calebpollman approved these changes Oct 5, 2022

View reviewed changes

katiegoines approved these changes Oct 6, 2022

View reviewed changes

Merge branch 'next-major-version/5' into next-major-version/merge-in-app

ddc2882

cshfang merged commit 08d83a3 into aws-amplify:next-major-version/5 Oct 6, 2022

cshfang deleted the next-major-version/merge-in-app branch October 6, 2022 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Next major version/merge in app #10430

Next major version/merge in app #10430

cshfang commented Oct 5, 2022

katiegoines Oct 5, 2022

cshfang Oct 5, 2022

lgtm-com bot commented Oct 5, 2022

jimblanc left a comment

jimblanc Oct 5, 2022

cshfang Oct 5, 2022

codecov-commenter commented Oct 5, 2022

calebpollman left a comment

lgtm-com bot commented Oct 6, 2022

Next major version/merge in app #10430

Next major version/merge in app #10430

Conversation

cshfang commented Oct 5, 2022

Description of changes

Description of how you validated changes

Checklist

katiegoines Oct 5, 2022

Choose a reason for hiding this comment

cshfang Oct 5, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Oct 5, 2022

jimblanc left a comment

Choose a reason for hiding this comment

jimblanc Oct 5, 2022

Choose a reason for hiding this comment

cshfang Oct 5, 2022

Choose a reason for hiding this comment

codecov-commenter commented Oct 5, 2022

Codecov Report

calebpollman left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Oct 6, 2022