Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert getProperties API #11419

Merged
merged 2 commits into from
May 26, 2023

Conversation

jimblanc
Copy link
Contributor

Description of changes

This change reverts the following commits related to getProperties due to type errors.

5d00b1f
3bed12b

Issue #, if available

Description of how you validated changes

Build.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jimblanc jimblanc marked this pull request as ready for review May 26, 2023 21:14
@jimblanc jimblanc requested a review from a team as a code owner May 26, 2023 21:14
@codecov-commenter
Copy link

Codecov Report

Merging #11419 (7179636) into main (5d00b1f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main   #11419      +/-   ##
==========================================
- Coverage   83.01%   83.00%   -0.02%     
==========================================
  Files         240      240              
  Lines       20212    20170      -42     
  Branches     4366     4356      -10     
==========================================
- Hits        16780    16743      -37     
+ Misses       3145     3140       -5     
  Partials      287      287              
Impacted Files Coverage Δ
packages/storage/src/providers/AWSS3Provider.ts 91.89% <ø> (+0.47%) ⬆️
packages/storage/src/Storage.ts 98.12% <100.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jimblanc jimblanc merged commit eeb6c9c into aws-amplify:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants