Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): allow 0BSD license #12761

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

ashwinkumar6
Copy link
Contributor

@ashwinkumar6 ashwinkumar6 commented Dec 27, 2023

Description of changes

GH actions workflow aws-amplify-dependency-check.yml checks for license of newly added packages on the PR.

Package tslib licensed under 0BSD is flagged since this isn't present in the list of allowed licenses. Update to allow the same

reference: Open Source Licenses for Distribution wiki

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@kvramyasri7 kvramyasri7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need approval from OSS folks internal Amazon.
Attaching a earlier discussion from Fransisco #12615 (comment)
TL;DR we can verify this with a ticket to osa and also would appreciate @ovalba

@ashwinkumar6
Copy link
Contributor Author

@kvramyasri7 thanks for referencing the previous discussion.
I think license 0BDS is present in the list of accepted licenses. Would we still need to raise a ticket to verify this

cc @jimblanc

@ashwinkumar6 ashwinkumar6 merged commit e13e180 into aws-amplify:main Jan 2, 2024
30 checks passed
@ashwinkumar6 ashwinkumar6 deleted the add-dep-review-license branch January 2, 2024 17:10
ashwinkumar6 added a commit that referenced this pull request Jan 2, 2024
* chore: enable e2e in-app test

* chore: correct integ sample path

* feat(ci): allow 0BSD license (#12761)

Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>

* fix(api): issue 12756 by exporting CONNECTION_STATE_CHANGE as a value (#12757)

fix: issue 12756 by exporting CONNECTION_STATE_CHANGE as a value

rather than as a type

Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>

---------

Co-authored-by: ManojNB <manojnb95@gmail.com>
Co-authored-by: ManojNB <manojnb@amazon.com>
Co-authored-by: Ashwin Kumar <ashwsrir@amazon.com>
Co-authored-by: Tim <timheilman@users.noreply.github.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants