Skip to content

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Aug 1, 2024

Description of changes

Fixed the constant mapped for network failure to say network error, not connection abort

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joon-won joon-won requested a review from a team as a code owner August 1, 2024 22:53
@joon-won joon-won changed the title Fix wrong error string mapping chore: Fix wrong error string mapping Aug 1, 2024
@joon-won joon-won marked this pull request as draft August 1, 2024 23:04
@joon-won joon-won marked this pull request as ready for review August 2, 2024 00:26
@joon-won joon-won requested a review from a team as a code owner August 2, 2024 00:26
@joon-won joon-won changed the title chore: Fix wrong error string mapping chore: Fix misleading error string mapping Aug 2, 2024
@joon-won joon-won changed the title chore: Fix misleading error string mapping chore: Fix misleading error string mapping in XHR client Aug 2, 2024
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joon-won joon-won merged commit e28d538 into aws-amplify:main Aug 2, 2024
@joon-won joon-won deleted the joonwonc/chore-fix-s3-error-code branch August 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants