Skip to content

fix: replace URL object with string concatenation for React Native compatibility #14516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix: replace URL object with string concatenation for React Native compatibility #14516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/auth/src/providers/cognito/apis/signInWithRedirect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,10 @@ const oauthSignIn = async ({
params.append('code_challenge', toCodeChallenge());
params.append('code_challenge_method', method);
}
const oAuthUrl = new URL('/oauth2/authorize', `https://${domain}/`);
oAuthUrl.search = params.toString();

// Using URL object is not supported in React Native as the `search` property is read-only
// See: https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Blob/URL.js
const oAuthUrl = `https://${domain}/oauth2/authorize?${params.toString()}`;

// this will only take effect in the following scenarios:
// 1. the user cancels the OAuth flow on web via back button, and
Expand All @@ -140,11 +142,8 @@ const oauthSignIn = async ({

// the following is effective only in react-native as openAuthSession resolves only in react-native
const { type, error, url } =
(await openAuthSession(
oAuthUrl.href,
redirectSignIn,
preferPrivateSession,
)) ?? {};
(await openAuthSession(oAuthUrl, redirectSignIn, preferPrivateSession)) ??
{};

try {
if (type === 'error') {
Expand Down
Loading