feat(authenticator): Add Select Auth Factor and Confirm Password UIs #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjroach
approved these changes
Oct 1, 2025
|
|
||
| import androidx.compose.ui.unit.dp | ||
|
|
||
| internal object AuthenticatorUiConstants { |
There was a problem hiding this comment.
Is this something you want o bring to other dp values. I see this is now being used but we are defining specific dp values without a constant throughout the rest of the PR.
There was a problem hiding this comment.
Yes eventually, for shared values anyways
Base automatically changed from
mattcreaser/passkey-prompt-ui
to
feat/passwordless
October 1, 2025 15:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds the UIs for the Select Auth Factor and Confirm Password steps. Does not yet hook up this functionality.
API naming subject to review.
How did you test these changes?
Documentation update required?
General Checklist
fix(liveness): message,fix(authenticator): message,fix(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.