Skip to content

fix: avoid invoking onCompletion handler twice for non-service errors #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2025
+471 −28
Merged

fix: avoid invoking onCompletion handler twice for non-service errors #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a966f78
fix: avoid invoking onCompletion handler twice for non-service errors
thisisabhash Oct 3, 2025
1b62ca3
update dependency to fix branch temporarily
thisisabhash Oct 9, 2025
e0272dd
update host app
thisisabhash Oct 10, 2025
3dea736
update code
thisisabhash Oct 10, 2025
2dccec5
update amplify dependency
thisisabhash Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions HostApp/HostApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@
A5A9AF5054D0FF13505B212A /* AmplifyConfig */ = {
isa = PBXGroup;
children = (
973619242BA378690003A590 /* awsconfiguration.json */,
973619232BA378690003A590 /* amplifyconfiguration.json */,
);
name = AmplifyConfig;
sourceTree = "<group>";
Expand Down Expand Up @@ -536,7 +534,7 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_ASSET_PATHS = "\"HostApp/Preview Content\"";
DEVELOPMENT_TEAM = W3DRXD72QU;
DEVELOPMENT_TEAM = N75V292K74;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = HostApp/Info.plist;
Expand All @@ -552,7 +550,7 @@
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.amazonaws.mobile.amplify.liveness.testing.hostapp;
PRODUCT_BUNDLE_IDENTIFIER = com.aws.amplify.liveness.testing.hostapp;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "DEBUG LANDMARK_DEBUG_MODE";
SWIFT_EMIT_LOC_STRINGS = YES;
Expand All @@ -570,7 +568,7 @@
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 1;
DEVELOPMENT_ASSET_PATHS = "\"HostApp/Preview Content\"";
DEVELOPMENT_TEAM = W3DRXD72QU;
DEVELOPMENT_TEAM = N75V292K74;
ENABLE_PREVIEWS = YES;
GENERATE_INFOPLIST_FILE = YES;
INFOPLIST_FILE = HostApp/Info.plist;
Expand All @@ -586,7 +584,7 @@
"@executable_path/Frameworks",
);
MARKETING_VERSION = 1.0;
PRODUCT_BUNDLE_IDENTIFIER = com.amazonaws.mobile.amplify.liveness.testing.hostapp;
PRODUCT_BUNDLE_IDENTIFIER = com.aws.amplify.liveness.testing.hostapp;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_EMIT_LOC_STRINGS = YES;
SWIFT_VERSION = 5.0;
Expand Down
234 changes: 225 additions & 9 deletions HostApp/HostApp.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions HostApp/HostApp/Views/ExampleLivenessView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ struct ExampleLivenessView: View {
LivenessCheckErrorContentView.invalidSignature
case .cameraNotAvailable:
LivenessCheckErrorContentView.cameraNotAvailable
case .validation:
LivenessCheckErrorContentView.validation
default:
LivenessCheckErrorContentView.unexpected
}
Expand Down
5 changes: 5 additions & 0 deletions HostApp/HostApp/Views/LivenessCheckErrorContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,11 @@ extension LivenessCheckErrorContentView {
name: "The signature on the request is invalid.",
description: "Ensure the device time is correct and try again."
)

static let validation = LivenessCheckErrorContentView(
name: "The input fails to satisfy the constraints specified by the service.",
description: "Please try again."
)

static let cameraNotAvailable = LivenessCheckErrorContentView(
name: "The camera could not be started.",
Expand Down
Loading
Loading