Skip to content

Conversation

amhinson
Copy link
Contributor

@amhinson amhinson commented Jun 8, 2020

Fixes: #1791

Description of changes:
Updating Push Notification docs in order to unblock customers going through documentation for the first time.

Overview:

  • Remove unnecessary npm & linking install instructions: Since this doc isn't meant to be an end-to-end tutorial, we can assume customers will already have a React Native project already created. Also, since autolinking has been available since RN 0.60+, we can simplify the linking instructions to just use npx pod-install.
  • Update Amplify setup: Since Amplify Push Notifications relies on Analytics to already be setup, the amplify init instructions are redundant. Also, amplify push is not needed after running amplify add notifications.
  • Update JS configuration example: Customers no longer need to call PushNotification.configure() explicitly, so all of the configuration should be inside Amplify.configure().
  • Update Android dependencies & remove unnecessary steps.
  • Certain iOS steps were removed, as they were unnecessary for the scope of this library (i.e. manage signing, ask on Launch)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push notifications android documentation update

2 participants