React native picker #4563
React native picker #4563
Conversation
abdallahshaban557
dismissed stale reviews from cshfang and timngyn
via
276c786
There was a problem hiding this comment.
We need a separate src/fragments/lib/storage/js/upload.mdx file for React Native which is a bit different than JS. The browser upload section needs to be removed for React Native. Additionally, I think the "React Native uploads" section needs to be renamed to "Media Uploads" or something similar to make more sense.
|
Need to update the instructions for using pre-built UI components for RN. Currently, it shows the instructions for the pre-built UI components for web platforms. Until we get the new Authenticator for RN, we should show instructions for setting up the old Authenticator. |
There was a problem hiding this comment.
I would like to see @chintannp's content requests met before approving this, thanks!
|
Both of the issues mentioned by @chintannp have been addressed. Can I please get approvals on this PR now? @chintannp @rachelnabors |
Co-authored-by: chintannp <88387035+chintannp@users.noreply.github.com>
Co-authored-by: chintannp <88387035+chintannp@users.noreply.github.com>
Co-authored-by: chintannp <88387035+chintannp@users.noreply.github.com>
|
@chintannp - I have resolved your new comments! Please let me know if there is anything else for me to fix! |
6 participants
Issue #, if available:
Description of changes:
Changes to add React Native as a platform picker to the libraries section. Took this opportunity to clean up the documentation as I progressed. This is still a draft.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.