Updated Vue getting started guide #4711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikCH
commented
Oct 17, 2022
| name: 'App', | ||
| async created() { | ||
| this.getTodos(); | ||
| this.subscribe(); |
There was a problem hiding this comment.
This was the only real change in this file. This was calling subscribe before it was added.
ErikCH
commented
Oct 17, 2022
| @@ -1,17 +1,25 @@ | |||
| Use the Vue CLI to bootstrap a new Vue 3 app (selecting the defaults will work for this project): | |||
| Use the Vue Vite powered `create-app` to bootstrap a new Vue 3 app (selecting the defaults will work for this project): | |||
There was a problem hiding this comment.
Moved guides to use the new create-app utility for Vue 3.
ErikCH
commented
Oct 17, 2022
| ## Vue Vite Config | ||
|
|
||
| Now that our Vue app is set up and Amplify is initialized, we're ready to add an API in the next step. | ||
| When working with a Vue `create-app` that uses [Vite](https://vitejs.dev) you must make a few additional modifications. Please follow the steps below. |
There was a problem hiding this comment.
Vite requires a little more configuration
siegerts
approved these changes
Oct 18, 2022
| }, | ||
| ] | ||
| } | ||
| }) |
There was a problem hiding this comment.
Nice!!!! This lines up with what we are recommending to customers as well - it will be nice to have a section in our docs we can refer customers to. I am probably going to take this part and add it to the troubleshooting side of the JS library guide. kevinold/repro-vite-amplify@4d6b422
katieklein
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This updates the getting started guide for Vue.js. Fixes some issues with the guide.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.