-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(Auth): Adding documentation for federation and switching auth flow type #4768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback
route: '/lib/auth/signin', | ||
filters: ['android', 'flutter', 'ios'] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please use the existing Switching authentication flows directory entry? Rather than creating another one just for iOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar is the case here.. If I use the existing one, Switch Auth would be the first option whereas we want it to come after sign in..
route: '/lib/auth/escapehatch', | ||
filters: ['android', 'ios'] | ||
}, | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here for advanced workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I use the existing directory entry, it messes up the order.. For example:
Advance workflows
would show up before Sign in
which we don't want.
} | ||
``` | ||
|
||
### Setup auth backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a section on how this works when we have auth type in amplifyconfiguration.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that as a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/fragments/lib/auth/ios/signin_with_custom_flow/50_custom_challenge.mdx
Outdated
Show resolved
Hide resolved
src/fragments/lib/auth/ios/signin_with_custom_flow/50_custom_challenge.mdx
Outdated
Show resolved
Hide resolved
…hallenge.mdx Co-authored-by: Jithin Roy <51138777+royjit@users.noreply.github.com>
…hallenge.mdx Co-authored-by: Jithin Roy <51138777+royjit@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.