Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Oct 31, 2022

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 marked this pull request as ready for review October 31, 2022 15:09
@harsh62 harsh62 requested review from a team as code owners October 31, 2022 15:09
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback

route: '/lib/auth/signin',
filters: ['android', 'flutter', 'ios']
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please use the existing Switching authentication flows directory entry? Rather than creating another one just for iOS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar is the case here.. If I use the existing one, Switch Auth would be the first option whereas we want it to come after sign in..

route: '/lib/auth/escapehatch',
filters: ['android', 'ios']
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here for advanced workflow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I use the existing directory entry, it messes up the order.. For example:

Advance workflows would show up before Sign in which we don't want.

}
```

### Setup auth backend
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a section on how this works when we have auth type in amplifyconfiguration.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that as a follow up

Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

harsh62 and others added 2 commits November 8, 2022 23:46
…hallenge.mdx

Co-authored-by: Jithin Roy <51138777+royjit@users.noreply.github.com>
…hallenge.mdx

Co-authored-by: Jithin Roy <51138777+royjit@users.noreply.github.com>
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harsh62 harsh62 merged commit c76ac72 into main Nov 9, 2022
@harsh62 harsh62 deleted the hsinghvq.updating-auth-documentation branch November 9, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants