Skip to content

Conversation

cwomack
Copy link
Member

@cwomack cwomack commented Nov 9, 2022

Issue #, if available:

Description of changes:
Fixes to the Next.JS documentation for Getting Started with Amplify after No current user errors occurred when following steps in guide. Everything works locally, however there is an issue with Hosting tied to vercel/next.js#41932 and the Frontend build failing for CI/CD. The error in the logs is the following:

Screen Shot 2022-11-09 at 12 17 06 PM

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cwomack cwomack requested a review from a team as a code owner November 9, 2022 19:33
@cwomack cwomack marked this pull request as draft November 9, 2022 19:33
@cwomack cwomack marked this pull request as ready for review November 9, 2022 19:35
@cwomack cwomack marked this pull request as draft November 9, 2022 19:38
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cwomack cwomack marked this pull request as ready for review November 9, 2022 19:42
Copy link
Contributor

@tannerabread tannerabread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me just wanted to discuss those few changes first

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
Copy link
Contributor

@tannerabread tannerabread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cwomack cwomack merged commit 96c43a9 into aws-amplify:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants