Skip to content

Conversation

abdallahshaban557
Copy link
Contributor

Description of changes:

Remove XR as a category from the documentation

Related GitHub issue #, if available:

N/A

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • [] Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?
    No redirects needed!

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abdallahshaban557 abdallahshaban557 added the amplify/js Issues tied to JS label Mar 29, 2023
@abdallahshaban557 abdallahshaban557 requested a review from a team as a code owner March 29, 2023 20:32
@mergify mergify bot added the redirects-needed Redirects need to be created for deleted pages label Mar 29, 2023
@mergify
Copy link

mergify bot commented Mar 29, 2023

@abdallahshaban557, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found 1 existing alert. Please check the repository Security tab to see all alerts.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5306.d39agkzf0cwtdz.amplifyapp.com

@abdallahshaban557
Copy link
Contributor Author

No redirects needed

@abdallahshaban557 abdallahshaban557 removed the redirects-needed Redirects need to be created for deleted pages label Apr 3, 2023
Copy link
Contributor

@wrpeck wrpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Bye bye, XR

@katieklein katieklein merged commit edd778f into main Apr 6, 2023
@katieklein katieklein deleted the Remove-XR branch April 6, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/js Issues tied to JS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants