Skip to content

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Mar 31, 2023

Description of changes:

Moving the description from the common library module to Flutter individually. This will stop the managing_credentials page showing up in other libraries.

image

Related GitHub issue: #5212

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner March 31, 2023 20:36
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found 1 existing alert. Please check the repository Security tab to see all alerts.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5326.d39agkzf0cwtdz.amplifyapp.com

@katieklein katieklein added amplify/js Issues tied to JS amplify/flutter product-owner-review-needed Current step in the approval process requires a PM review technical-review-needed labels Apr 4, 2023
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdallahshaban557 abdallahshaban557 added ready-to-merge all approvals are in and this PR is ready for a docs engineer to merge and removed product-owner-review-needed Current step in the approval process requires a PM review technical-review-needed labels Apr 5, 2023
@katieklein katieklein merged commit e06df5e into main Apr 6, 2023
@katieklein katieklein deleted the harsh62-5212 branch April 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/flutter amplify/js Issues tied to JS ready-to-merge all approvals are in and this PR is ready for a docs engineer to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants