Skip to content

Conversation

wrpeck
Copy link
Contributor

@wrpeck wrpeck commented Apr 4, 2023

Description of changes:

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

image
image
image
image

@wrpeck wrpeck requested a review from a team as a code owner April 4, 2023 23:15
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5341.d39agkzf0cwtdz.amplifyapp.com

nearestnabors
nearestnabors previously approved these changes Apr 4, 2023
Copy link
Contributor

@nearestnabors nearestnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed with Wesley. Good step in the right direction!

@nearestnabors nearestnabors added the amplify/studio Issues and PRs related to amplify studio documentation label Apr 4, 2023
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wrpeck wrpeck merged commit 2d8d7b8 into main Apr 7, 2023
@wrpeck wrpeck deleted the wrpeck/studio-login-improvement branch April 7, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/editorial amplify/studio Issues and PRs related to amplify studio documentation technical-review-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants