Skip to content

Conversation

cshfang
Copy link
Contributor

@cshfang cshfang commented Apr 5, 2023

Description of changes:

This PR adds public documentation for Amplify Push Notification for React Native

redirects are needed

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mergify mergify bot added the redirects-needed Redirects need to be created for deleted pages label Apr 5, 2023
@mergify
Copy link

mergify bot commented Apr 5, 2023

@cshfang, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)

  • What is the target address of the redirect? (Where are you trying to redirect to?)

  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5344.d39agkzf0cwtdz.amplifyapp.com

@cshfang
Copy link
Contributor Author

cshfang commented Apr 5, 2023

@cshfang, since a file was deleted from the src/pages and/or src/fragments directories, redirects might need to be set up so these previous pages do not 404. If redirects are needed, please answer these questions for each redirect that is needed:

  • What is the source address of the redirect? (Where are you trying to redirect from?)
  • What is the target address of the redirect? (Where are you trying to redirect to?)
  • Type of redirect? 301 - permanent redirect or 302 - temporary redirect? (More info on Amplify Hosting redirects here: https://docs.aws.amazon.com/amplify/latest/userguide/redirects.html)

src/pages/lib/push-notifications/overview/q/platform/[platform].mdx
src/pages/lib/push-notifications/working-with-api/q/platform/[platform].mdx ->

src/pages/lib/push-notifications/getting-started/q/platform/[platform].mdx (302)

src/fragments/lib/push-notifications/js/getting-started.mdx
src/fragments/lib/push-notifications/js/overview.mdx
src/fragments/lib/push-notifications/js/working-with-api.mdx ->

src/fragments/lib/push-notifications/common/getting-started.mdx (302)

src/fragments/lib/push-notifications/js/testing.mdx ->

src/fragments/lib/push-notifications/common/testing.mdx (302)

@timngyn timngyn added the amplify/js Issues tied to JS label Apr 5, 2023
Copy link
Contributor

@tannerabread tannerabread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments are pretty nit-picky but I gotta say I love what you've done with the imports/fragments. We should probably try to make that a standard going forward

cshfang and others added 13 commits April 6, 2023 09:37
…ted/50_integrate_native_modules.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
…r/10_get_auth_user.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
…tup-apns.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
…notifications/enable-rich-notifications.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
…notifications/enable-rich-notifications.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
…h_notifications/notification-lifecycle.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
…issions/request-permissions.mdx

Co-authored-by: Bannon Tanner <bannon.n.tanner@gmail.com>
cshfang and others added 14 commits April 7, 2023 15:17
…unt/app-badge-count.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…unt/app-badge-count.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…ted/10_pre_req.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…ted/40_install_lib.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…h_notifications/notification-lifecycle.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…h_notifications/notification-received.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…_previous_version/migrate-from-previous-version.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…_previous_version/migrate-from-previous-version.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…_previous_version/migrate-from-previous-version.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…_previous_version/migrate-from-previous-version.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…issions/request-permissions.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
…issions/request-permissions.mdx

Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
Co-authored-by: Jim Blanchard <jim.l.blanchard@gmail.com>
jimblanc
jimblanc previously approved these changes Apr 7, 2023
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cshfang cshfang dismissed stale reviews from abdallahshaban557 and jimblanc via b7e7682 April 10, 2023 23:52
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katieklein katieklein removed product-owner-review-needed Current step in the approval process requires a PM review technical-review-needed labels Apr 12, 2023
@katieklein katieklein marked this pull request as ready for review April 12, 2023 21:38
@katieklein katieklein requested a review from a team as a code owner April 12, 2023 21:38
@katieklein katieklein added redirects-added Redirects have been created for deleted pages and removed redirects-needed Redirects need to be created for deleted pages labels Apr 12, 2023
@katieklein katieklein merged commit f169e9b into aws-amplify:main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/js Issues tied to JS redirects-added Redirects have been created for deleted pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants