Skip to content

Conversation

tannerabread
Copy link
Contributor

Description of changes:

Missing comma found when copying IAM policy

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tannerabread tannerabread added the amplify/js Issues tied to JS label Apr 5, 2023
@tannerabread tannerabread requested review from a team and abdallahshaban557 April 5, 2023 18:26
@tannerabread tannerabread requested a review from a team as a code owner April 5, 2023 18:26
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5349.d39agkzf0cwtdz.amplifyapp.com

Copy link
Member

@cwomack cwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@abdallahshaban557 abdallahshaban557 added the ready-to-merge all approvals are in and this PR is ready for a docs engineer to merge label Apr 5, 2023
@katieklein katieklein merged commit 5adcf25 into main Apr 6, 2023
@katieklein katieklein deleted the predictions-typo branch April 6, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/js Issues tied to JS ready-to-merge all approvals are in and this PR is ready for a docs engineer to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants