Skip to content

Conversation

tannerabread
Copy link
Contributor

@tannerabread tannerabread commented Apr 5, 2023

Description of changes:

Fixes broken Block switcher that displayed an extra selector for JavaScript on this page and removed the content at the bottom of the section
Apparently <Block> doesn't play nice without newlines between the component and the content

Current Broken version:
image

Fixed version:
image

Related GitHub issue #, if available:

Resolves #5316

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tannerabread tannerabread requested review from a team and renebrandel April 5, 2023 22:59
@tannerabread tannerabread requested a review from a team as a code owner April 5, 2023 22:59
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Copy link
Contributor

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@david-mcafee david-mcafee added API GraphQL p2 incorrect info. ie a bug amplify/data Issue related to aws-amplify/amplify-category-api labels Apr 5, 2023
@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5351.d39agkzf0cwtdz.amplifyapp.com

@katieklein katieklein merged commit 8debbf6 into aws-amplify:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/data Issue related to aws-amplify/amplify-category-api API GraphQL p2 incorrect info. ie a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feedback](RN/JS) Extra Selector for JavaScript on GraphQL Configure authorization modes

6 participants