Drop PyPI mock test dependency #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to just drop python 2 support at this point. Thanks for submitting this PR. |
You’re welcome. Are you ready to drop Python 2 support immediately? I can easily add a commit to this PR that removes the workarounds for Python 2, if that is helpful. |
|
Should be covered in #2195 |
|
Just merged in the python 2.7 EOL changes |
|
It looks like #2195 did not remove the PyPI |
The functionality is in the standard library as unittest.mock beginning with Python 3.3. Since aws-cloudformation#2195 removed support for everything below Python 3.6, the dependency can be removed unconditionally.
musicinmybrain
force-pushed
the
unittest-mock
branch
from
ff1d4fb
to
de5f17e
Compare
|
The dependency removal is now unconditional, which makes for a much cleaner PR. |
musicinmybrain
changed the title
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 20, 2022
python-mock is no longer necessary after aws-cloudformation/cfn-lint#2190 git-svn-id: file:///srv/repos/svn-community/svn@1111241 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jan 20, 2022
python-mock is no longer necessary after aws-cloudformation/cfn-lint#2190 git-svn-id: file:///srv/repos/svn-community/svn@1111241 9fca08f4-af9d-4005-b8df-a31f2cc04f65
kddejong
pushed a commit
to kddejong/cfn-python-lint
that referenced
this pull request
Feb 28, 2022
The functionality is in the standard library as unittest.mock beginning with Python 3.3. Since aws-cloudformation#2195 removed support for everything below Python 3.6, the dependency can be removed unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality is in the standard library as
unittest.mockbeginning with Python 3.3.Issue #, if available: (none)
Description of changes:
In any tests, prefer to import from
unittest.mockin the Python 3.3+ standard library, falling back to the PyPImockbackport package only where required (Python 2.7). Drop themockdependency fromtox.inifor Python 3.3+, too.See https://fedoraproject.org/wiki/Changes/DeprecatePythonMock for further context.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.