Remove support for everything below python 3.6 #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerna-p
approved these changes
Jan 11, 2022
kddejong
force-pushed
the
lifecycle/python/2.7
branch
2 times, most recently
from
3f4f98e
to
7336028
Compare
|
after this is in I will do another PR to rip out |
kddejong
force-pushed
the
lifecycle/python/2.7
branch
from
163e487
to
ae74b6e
Compare
kddejong
force-pushed
the
lifecycle/python/2.7
branch
from
ae74b6e
to
8592942
Compare
hawflau
approved these changes
Jan 11, 2022
|
We are still getting downloads per day: |
musicinmybrain
added a commit
to musicinmybrain/cfn-lint
that referenced
this pull request
Jan 13, 2022
The functionality is in the standard library as unittest.mock beginning with Python 3.3. Since aws-cloudformation#2195 removed support for everything below Python 3.6, the dependency can be removed unconditionally.
kddejong
pushed a commit
that referenced
this pull request
Jan 14, 2022
The functionality is in the standard library as unittest.mock beginning with Python 3.3. Since #2195 removed support for everything below Python 3.6, the dependency can be removed unconditionally.
kddejong
added a commit
to kddejong/cfn-python-lint
that referenced
this pull request
Feb 28, 2022
* Remove support for everything below python 3.6 * Remove additional python 2.7 considerations
kddejong
pushed a commit
to kddejong/cfn-python-lint
that referenced
this pull request
Feb 28, 2022
The functionality is in the standard library as unittest.mock beginning with Python 3.3. Since aws-cloudformation#2195 removed support for everything below Python 3.6, the dependency can be removed unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.